From: David Miller <davem@davemloft.net>
To: jeffrey.t.kirsher@intel.com
Cc: lihong.yang@intel.com, netdev@vger.kernel.org,
nhorman@redhat.com, sassmann@redhat.com
Subject: Re: [net-next 2/2] i40e: Check and set the PF driver state first in i40e_ndo_set_vf_mac
Date: Wed, 05 Jun 2019 16:53:50 -0700 (PDT) [thread overview]
Message-ID: <20190605.165350.2288911528761294407.davem@davemloft.net> (raw)
In-Reply-To: <20190605194516.10125-2-jeffrey.t.kirsher@intel.com>
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Date: Wed, 5 Jun 2019 12:45:16 -0700
> From: Lihong Yang <lihong.yang@intel.com>
>
> The PF driver state flag __I40E_VIRTCHNL_OP_PENDING needs to be
> checked and set at the beginning of i40e_ndo_set_vf_mac. Otherwise,
> if there are error conditions before it, the flag will be cleared
> unexpectedly by this function to cause potential race conditions.
> Hence move the check to the top of this function.
>
> Signed-off-by: Lihong Yang <lihong.yang@intel.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Applied.
next prev parent reply other threads:[~2019-06-05 23:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-05 19:45 [net-next 1/2] i40e: Do not check VF state in i40e_ndo_get_vf_config Jeff Kirsher
2019-06-05 19:45 ` [net-next 2/2] i40e: Check and set the PF driver state first in i40e_ndo_set_vf_mac Jeff Kirsher
2019-06-05 23:53 ` David Miller [this message]
2019-06-05 23:53 ` [net-next 1/2] i40e: Do not check VF state in i40e_ndo_get_vf_config David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190605.165350.2288911528761294407.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=lihong.yang@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).