From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=chJ4=UF=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham
	autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 2F744C28CC5
	for <netdev@archiver.kernel.org>; Thu,  6 Jun 2019 01:41:20 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id E2A5F2070B
	for <netdev@archiver.kernel.org>; Thu,  6 Jun 2019 01:41:19 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726608AbfFFBlT (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Wed, 5 Jun 2019 21:41:19 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:44018 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726573AbfFFBlS (ORCPT
        <rfc822;netdev@vger.kernel.org>); Wed, 5 Jun 2019 21:41:18 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id D1BEC144CBBF1;
        Wed,  5 Jun 2019 18:41:17 -0700 (PDT)
Date:   Wed, 05 Jun 2019 18:41:12 -0700 (PDT)
Message-Id: <20190605.184112.199298828409456934.davem@davemloft.net>
To:     natechancellor@gmail.com
Cc:     liuhangbin@gmail.com, netdev@vger.kernel.org,
        gregkh@linuxfoundation.org, zenczykowski@gmail.com,
        lorenzo@google.com, dsa@cumulusnetworks.com, thaller@redhat.com,
        yaro330@gmail.com
Subject: Re: [PATCH net] Revert "fib_rules: return 0 directly if an exactly
 same rule exists when NLM_F_EXCL not supplied"
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190606012351.GA29571@archlinux-epyc>
References: <20190605042714.28532-1-liuhangbin@gmail.com>
        <20190605.175526.1448552541340120763.davem@davemloft.net>
        <20190606012351.GA29571@archlinux-epyc>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 05 Jun 2019 18:41:18 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Nathan Chancellor <natechancellor@gmail.com>
Date: Wed, 5 Jun 2019 18:23:51 -0700

> On Wed, Jun 05, 2019 at 05:55:26PM -0700, David Miller wrote:
>> From: Hangbin Liu <liuhangbin@gmail.com>
>> Date: Wed,  5 Jun 2019 12:27:14 +0800
>> 
>> > This reverts commit e9919a24d3022f72bcadc407e73a6ef17093a849.
>> > 
>> > Nathan reported the new behaviour breaks Android, as Android just add
>> > new rules and delete old ones.
>> > 
>> > If we return 0 without adding dup rules, Android will remove the new
>> > added rules and causing system to soft-reboot.
>> > 
>> > Reported-by: Nathan Chancellor <natechancellor@gmail.com>
>> > Fixes: e9919a24d302 ("fib_rules: return 0 directly if an exactly same rule exists when NLM_F_EXCL not supplied")
>> > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
>> 
>> Applied.
> 
> Please ensure this gets queued up for stable, as that is where I noticed
> the issue.

It is queued up, thanks for asking.

I'll try to get this propagated as soon as possible.

Thanks again.