netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsahern@kernel.org>
To: davem@davemloft.net, netdev@vger.kernel.org
Cc: idosch@mellanox.com, kafai@fb.com, weiwan@google.com,
	sbrivio@redhat.com, David Ahern <dsahern@gmail.com>
Subject: [PATCH net-next 08/19] ipv6: Handle all fib6_nh in a nexthop in __ip6_route_redirect
Date: Wed,  5 Jun 2019 16:15:12 -0700	[thread overview]
Message-ID: <20190605231523.18424-9-dsahern@kernel.org> (raw)
In-Reply-To: <20190605231523.18424-1-dsahern@kernel.org>

From: David Ahern <dsahern@gmail.com>

Add a hook in __ip6_route_redirect to handle a nexthop struct in a
fib6_info. Use nexthop_for_each_fib6_nh and fib6_nh_redirect_match
to call ip6_redirect_nh_match for each fib6_nh looking for a match.

Signed-off-by: David Ahern <dsahern@gmail.com>
---
 net/ipv6/route.c | 39 +++++++++++++++++++++++++++++++++++----
 1 file changed, 35 insertions(+), 4 deletions(-)

diff --git a/net/ipv6/route.c b/net/ipv6/route.c
index f1fd376b6035..15d9dad7e070 100644
--- a/net/ipv6/route.c
+++ b/net/ipv6/route.c
@@ -2791,6 +2791,21 @@ static bool ip6_redirect_nh_match(const struct fib6_result *res,
 	return true;
 }
 
+struct fib6_nh_rd_arg {
+	struct fib6_result	*res;
+	struct flowi6		*fl6;
+	const struct in6_addr	*gw;
+	struct rt6_info		**ret;
+};
+
+static int fib6_nh_redirect_match(struct fib6_nh *nh, void *_arg)
+{
+	struct fib6_nh_rd_arg *arg = _arg;
+
+	arg->res->nh = nh;
+	return ip6_redirect_nh_match(arg->res, arg->fl6, arg->gw, arg->ret);
+}
+
 /* Handle redirects */
 struct ip6rd_flowi {
 	struct flowi6 fl6;
@@ -2806,6 +2821,12 @@ static struct rt6_info *__ip6_route_redirect(struct net *net,
 	struct ip6rd_flowi *rdfl = (struct ip6rd_flowi *)fl6;
 	struct rt6_info *ret = NULL;
 	struct fib6_result res = {};
+	struct fib6_nh_rd_arg arg = {
+		.res = &res,
+		.fl6 = fl6,
+		.gw  = &rdfl->gateway,
+		.ret = &ret
+	};
 	struct fib6_info *rt;
 	struct fib6_node *fn;
 
@@ -2830,14 +2851,24 @@ static struct rt6_info *__ip6_route_redirect(struct net *net,
 restart:
 	for_each_fib6_node_rt_rcu(fn) {
 		res.f6i = rt;
-		res.nh = rt->fib6_nh;
-
 		if (fib6_check_expired(rt))
 			continue;
 		if (rt->fib6_flags & RTF_REJECT)
 			break;
-		if (ip6_redirect_nh_match(&res, fl6, &rdfl->gateway, &ret))
-			goto out;
+		if (unlikely(rt->nh)) {
+			if (nexthop_is_blackhole(rt->nh))
+				continue;
+			/* on match, res->nh is filled in and potentially ret */
+			if (nexthop_for_each_fib6_nh(rt->nh,
+						     fib6_nh_redirect_match,
+						     &arg))
+				goto out;
+		} else {
+			res.nh = rt->fib6_nh;
+			if (ip6_redirect_nh_match(&res, fl6, &rdfl->gateway,
+						  &ret))
+				goto out;
+		}
 	}
 
 	if (!rt)
-- 
2.11.0


  parent reply	other threads:[~2019-06-05 23:15 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-05 23:15 [PATCH net-next 00/19] net: Enable nexthop objects with IPv4 and IPv6 routes David Ahern
2019-06-05 23:15 ` [PATCH net-next 01/19] nexthops: Add ipv6 helper to walk all fib6_nh in a nexthop struct David Ahern
2019-06-06 21:52   ` David Miller
2019-06-06 22:01     ` David Ahern
2019-06-05 23:15 ` [PATCH net-next 02/19] ipv6: Handle all fib6_nh in a nexthop in fib6_drop_pcpu_from David Ahern
2019-06-05 23:15 ` [PATCH net-next 03/19] ipv6: Handle all fib6_nh in a nexthop in rt6_device_match David Ahern
2019-06-05 23:15 ` [PATCH net-next 04/19] ipv6: Handle all fib6_nh in a nexthop in __find_rr_leaf David Ahern
2019-06-05 23:15 ` [PATCH net-next 05/19] ipv6: Handle all fib6_nh in a nexthop in rt6_nlmsg_size David Ahern
2019-06-05 23:15 ` [PATCH net-next 06/19] ipv6: Handle all fib6_nh in a nexthop in fib6_info_uses_dev David Ahern
2019-06-05 23:15 ` [PATCH net-next 07/19] ipv6: Handle all fib6_nh in a nexthop in exception handling David Ahern
2019-06-05 23:15 ` David Ahern [this message]
2019-06-05 23:15 ` [PATCH net-next 09/19] ipv6: Handle all fib6_nh in a nexthop in rt6_do_redirect David Ahern
2019-06-05 23:15 ` [PATCH net-next 10/19] ipv6: Handle all fib6_nh in a nexthop in mtu updates David Ahern
2019-06-05 23:15 ` [PATCH net-next 11/19] ipv4: Allow routes to use nexthop objects David Ahern
2019-06-05 23:15 ` [PATCH net-next 12/19] ipv4: Optimization for fib_info lookup with nexthops David Ahern
2019-06-05 23:15 ` [PATCH net-next 13/19] ipv6: Allow routes to use nexthop objects David Ahern
2019-06-05 23:15 ` [PATCH net-next 14/19] nexthops: add support for replace David Ahern
2019-06-06 21:52   ` David Miller
2019-06-05 23:15 ` [PATCH net-next 15/19] selftests: pmtu: Move running of test into a new function David Ahern
2019-06-06  5:51   ` Stefano Brivio
2019-06-05 23:15 ` [PATCH net-next 16/19] selftests: pmtu: Move route installs to " David Ahern
2019-06-06  5:51   ` Stefano Brivio
2019-06-05 23:15 ` [PATCH net-next 17/19] selftests: pmtu: Add support for routing via nexthop objects David Ahern
2019-06-06  5:51   ` Stefano Brivio
2019-06-05 23:15 ` [PATCH net-next 18/19] selftests: icmp_redirect: " David Ahern
2019-06-05 23:15 ` [PATCH net-next 19/19] selftests: Add test with multiple prefixes using single nexthop David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190605231523.18424-9-dsahern@kernel.org \
    --to=dsahern@kernel.org \
    --cc=davem@davemloft.net \
    --cc=dsahern@gmail.com \
    --cc=idosch@mellanox.com \
    --cc=kafai@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=sbrivio@redhat.com \
    --cc=weiwan@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).