From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A62C04AB5 for ; Thu, 6 Jun 2019 17:30:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 20B2C2083E for ; Thu, 6 Jun 2019 17:30:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730158AbfFFRaf (ORCPT ); Thu, 6 Jun 2019 13:30:35 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54564 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726924AbfFFRad (ORCPT ); Thu, 6 Jun 2019 13:30:33 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 225A514DB3D2B; Thu, 6 Jun 2019 10:30:33 -0700 (PDT) Date: Thu, 06 Jun 2019 10:30:32 -0700 (PDT) Message-Id: <20190606.103032.1177448114269235903.davem@davemloft.net> To: olivier.matz@6wind.com Cc: netdev@vger.kernel.org, hannes@stressinduktion.org Subject: Re: [PATCH net 0/2] ipv6: fix EFAULT on sendto with icmpv6 and hdrincl From: David Miller In-Reply-To: <20190606071519.5841-1-olivier.matz@6wind.com> References: <20190606071519.5841-1-olivier.matz@6wind.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 06 Jun 2019 10:30:33 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Olivier Matz Date: Thu, 6 Jun 2019 09:15:17 +0200 > The following code returns EFAULT (Bad address): > > s = socket(AF_INET6, SOCK_RAW, IPPROTO_ICMPV6); > setsockopt(s, SOL_IPV6, IPV6_HDRINCL, 1); > sendto(ipv6_icmp6_packet, addr); /* returns -1, errno = EFAULT */ > > The problem is fixed in the second patch. The first one aligns the > code to ipv4, to avoid a race condition in the second patch. Series applied and queued up for -stable. Thanks.