From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A042FC04AB5 for ; Thu, 6 Jun 2019 17:33:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84B7D2083D for ; Thu, 6 Jun 2019 17:33:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730152AbfFFRdH (ORCPT ); Thu, 6 Jun 2019 13:33:07 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:54606 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726924AbfFFRdH (ORCPT ); Thu, 6 Jun 2019 13:33:07 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5F18614DD3CC6; Thu, 6 Jun 2019 10:33:06 -0700 (PDT) Date: Thu, 06 Jun 2019 10:33:05 -0700 (PDT) Message-Id: <20190606.103305.472940054915337291.davem@davemloft.net> To: yanjun.zhu@oracle.com Cc: santosh.shilimkar@oracle.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com Subject: Re: [PATCH 1/1] net: rds: fix memory leak in rds_ib_flush_mr_pool From: David Miller In-Reply-To: <1559808003-1030-1-git-send-email-yanjun.zhu@oracle.com> References: <1559808003-1030-1-git-send-email-yanjun.zhu@oracle.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 06 Jun 2019 10:33:06 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Zhu Yanjun Date: Thu, 6 Jun 2019 04:00:03 -0400 > When the following tests last for several hours, the problem will occur. ... > When ibmr_ret is NULL, llist_entry is not executed. clean_nodes->next > instead of clean_nodes is added in clean_list. > So clean_nodes is discarded. It can not be used again. > The workqueue is executed periodically. So more and more clean_nodes are > discarded. Finally the clean_list is NULL. > Then this problem will occur. > > Fixes: 1bc144b62524 ("net, rds, Replace xlist in net/rds/xlist.h with llist") > Signed-off-by: Zhu Yanjun Applied and queued up for -stable.