From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D91AC28CC5 for ; Thu, 6 Jun 2019 01:37:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E4BF82070B for ; Thu, 6 Jun 2019 01:37:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559785032; bh=HXQXWCIOFNBXcHkDWz5g3maJSD2bDpycPPbzZqiERlA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=BViSMvHsjfhwfQyeZjP0dhdRze/zKib2Sf17qNeXHIl7xm5Jqq5MmOv83NqMemUe/ YkGY08vunLZ4TiFYw4ljeGLtmwKa1mXAM9ELzdGT7bPnFHqL922mfpit64lXP8CM/l o1fMVid69ZZAzuwHN8ALD6v8/jUF9uvqoLGvUVsQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726674AbfFFBhI (ORCPT ); Wed, 5 Jun 2019 21:37:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:44152 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726593AbfFFBhH (ORCPT ); Wed, 5 Jun 2019 21:37:07 -0400 Received: from dragon (li1264-180.members.linode.com [45.79.165.180]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8AE172083E; Thu, 6 Jun 2019 01:37:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1559785026; bh=HXQXWCIOFNBXcHkDWz5g3maJSD2bDpycPPbzZqiERlA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JwXzOdFoeAv26TPTbXgc6pLZYvUDuXltoVags/NfK65oP35Vu04hl1YZ0y3GFbz+k yABJ4UzyntgwzeLVX3CO5vGVUQZ7/YyUVIVZSNEAhIJPD/pQ79Lmj1ugag4NxekfNj uVP7Nm5r1mO57sIFuzdg/DsObfKtVyYd2LvetsNo= Date: Thu, 6 Jun 2019 09:36:49 +0800 From: Shawn Guo To: Vladimir Oltean Cc: leoyang.li@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, lkml , netdev Subject: Re: [PATCH v2] ARM: dts: Introduce the NXP LS1021A-TSN board Message-ID: <20190606013647.GQ29853@dragon> References: <20190529221222.19276-1-olteanv@gmail.com> <20190606010429.GP29853@dragon> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Jun 06, 2019 at 04:15:00AM +0300, Vladimir Oltean wrote: > On Thu, 6 Jun 2019 at 04:04, Shawn Guo wrote: > > > > On Thu, May 30, 2019 at 01:12:22AM +0300, Vladimir Oltean wrote: > > > The LS1021A-TSN is a development board built by VVDN/Argonboards in > > > partnership with NXP. > > > > > > It features the LS1021A SoC and the first-generation SJA1105T Ethernet > > > switch for prototyping implementations of a subset of IEEE 802.1 TSN > > > standards. > > > > > > It has two regular Ethernet ports and four switched, TSN-capable ports. > > > > > > It also features: > > > - One Arduino header > > > - One expansion header > > > - Two USB 3.0 ports > > > - One mini PCIe slot > > > - One SATA interface > > > - Accelerometer, gyroscope, temperature sensors > > > > > > Signed-off-by: Vladimir Oltean > > > --- > > > Changes from v1: > > > - Applied Shawn's feedback > > > - Introduced QSPI flash node > > > > > > v1 patch available at: > > > https://patchwork.kernel.org/patch/10930451/ > > > > > > arch/arm/boot/dts/Makefile | 1 + > > > arch/arm/boot/dts/ls1021a-tsn.dts | 288 ++++++++++++++++++++++++++++++ > > > 2 files changed, 289 insertions(+) > > > create mode 100644 arch/arm/boot/dts/ls1021a-tsn.dts > > > > > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > > > index dab2914fa293..a4eb4ca5e148 100644 > > > --- a/arch/arm/boot/dts/Makefile > > > +++ b/arch/arm/boot/dts/Makefile > > > @@ -602,6 +602,7 @@ dtb-$(CONFIG_SOC_IMX7ULP) += \ > > > dtb-$(CONFIG_SOC_LS1021A) += \ > > > ls1021a-moxa-uc-8410a.dtb \ > > > ls1021a-qds.dtb \ > > > + ls1021a-tsn.dtb \ > > > ls1021a-twr.dtb > > > dtb-$(CONFIG_SOC_VF610) += \ > > > vf500-colibri-eval-v3.dtb \ > > > diff --git a/arch/arm/boot/dts/ls1021a-tsn.dts b/arch/arm/boot/dts/ls1021a-tsn.dts > > > new file mode 100644 > > > index 000000000000..b05774eac92e > > > --- /dev/null > > > +++ b/arch/arm/boot/dts/ls1021a-tsn.dts > > > @@ -0,0 +1,288 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* Copyright 2016-2018 NXP Semiconductors > > > + * Copyright 2019 Vladimir Oltean > > > + */ > > > + > > > +/dts-v1/; > > > +#include "ls1021a.dtsi" > > > + > > > +/ { > > > + model = "NXP LS1021A-TSN Board"; > > > + > > > + sys_mclk: clock-mclk { > > > + compatible = "fixed-clock"; > > > + #clock-cells = <0>; > > > + clock-frequency = <24576000>; > > > + }; > > > + > > > + reg_vdda_codec: regulator-3V3 { > > > + compatible = "regulator-fixed"; > > > + regulator-name = "3P3V"; > > > + regulator-min-microvolt = <3300000>; > > > + regulator-max-microvolt = <3300000>; > > > + regulator-always-on; > > > + }; > > > + > > > + reg_vddio_codec: regulator-2V5 { > > > + compatible = "regulator-fixed"; > > > + regulator-name = "2P5V"; > > > + regulator-min-microvolt = <2500000>; > > > + regulator-max-microvolt = <2500000>; > > > + regulator-always-on; > > > + }; > > > +}; > > > + > > > +&enet0 { > > > + tbi-handle = <&tbi0>; > > > + phy-handle = <&sgmii_phy2>; > > > + phy-mode = "sgmii"; > > > + status = "okay"; > > > +}; > > > + > > > +&enet1 { > > > + tbi-handle = <&tbi1>; > > > + phy-handle = <&sgmii_phy1>; > > > + phy-mode = "sgmii"; > > > + status = "okay"; > > > +}; > > > + > > > +/* RGMII delays added via PCB traces */ > > > +&enet2 { > > > + phy-mode = "rgmii"; > > > + status = "okay"; > > > + > > > + fixed-link { > > > + speed = <1000>; > > > + full-duplex; > > > + }; > > > +}; > > > + > > > +&dspi0 { > > > + bus-num = <0>; > > > + status = "okay"; > > > + > > > + /* ADG704BRMZ 1:4 mux/demux */ > > > + sja1105: ethernet-switch@1 { > > > + reg = <0x1>; > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + compatible = "nxp,sja1105t"; > > > + /* 12 MHz */ > > > + spi-max-frequency = <12000000>; > > > + /* Sample data on trailing clock edge */ > > > + spi-cpha; > > > + fsl,spi-cs-sck-delay = <1000>; > > > + fsl,spi-sck-cs-delay = <1000>; > > > + > > > + ports { > > > + #address-cells = <1>; > > > + #size-cells = <0>; > > > + > > > + port@0 { > > > + /* ETH5 written on chassis */ > > > + label = "swp5"; > > > + phy-handle = <&rgmii_phy6>; > > > + phy-mode = "rgmii-id"; > > > + reg = <0>; > > > + }; > > > + > > > + port@1 { > > > + /* ETH2 written on chassis */ > > > + label = "swp2"; > > > + phy-handle = <&rgmii_phy3>; > > > + phy-mode = "rgmii-id"; > > > + reg = <1>; > > > + }; > > > + > > > + port@2 { > > > + /* ETH3 written on chassis */ > > > + label = "swp3"; > > > + phy-handle = <&rgmii_phy4>; > > > + phy-mode = "rgmii-id"; > > > + reg = <2>; > > > + }; > > > + > > > + port@3 { > > > + /* ETH4 written on chassis */ > > > + label = "swp4"; > > > + phy-handle = <&rgmii_phy5>; > > > + phy-mode = "rgmii-id"; > > > + reg = <3>; > > > + }; > > > + > > > + port@4 { > > > + /* Internal port connected to eth2 */ > > > + ethernet = <&enet2>; > > > + phy-mode = "rgmii"; > > > + reg = <4>; > > > + > > > + fixed-link { > > > + speed = <1000>; > > > + full-duplex; > > > + }; > > > + }; > > > + }; > > > + }; > > > +}; > > > + > > > +&mdio0 { > > > + /* AR8031 */ > > > + sgmii_phy1: ethernet-phy@1 { > > > + reg = <0x1>; > > > + }; > > > + > > > + /* AR8031 */ > > > + sgmii_phy2: ethernet-phy@2 { > > > + reg = <0x2>; > > > + }; > > > + > > > + /* BCM5464 quad PHY */ > > > + rgmii_phy3: ethernet-phy@3 { > > > + reg = <0x3>; > > > + }; > > > + > > > + rgmii_phy4: ethernet-phy@4 { > > > + reg = <0x4>; > > > + }; > > > + > > > + rgmii_phy5: ethernet-phy@5 { > > > + reg = <0x5>; > > > + }; > > > + > > > + rgmii_phy6: ethernet-phy@6 { > > > + reg = <0x6>; > > > + }; > > > + > > > + /* SGMII PCS for enet0 */ > > > + tbi0: tbi-phy@1f { > > > + reg = <0x1f>; > > > + device_type = "tbi-phy"; > > > + }; > > > +}; > > > + > > > +&mdio1 { > > > + /* SGMII PCS for enet1 */ > > > + tbi1: tbi-phy@1f { > > > + reg = <0x1f>; > > > + device_type = "tbi-phy"; > > > + }; > > > +}; > > > + > > > +&i2c0 { > > > + status = "okay"; > > > + > > > + /* 3 axis accelerometer */ > > > + accelerometer@1e { > > > + compatible = "fsl,fxls8471"; > > > + position = <0>; > > > + reg = <0x1e>; > > > + }; > > > + > > > + /* Audio codec (SAI2) */ > > > + codec@2a { > > > > audio-codec for node name. > > > > > + compatible = "fsl,sgtl5000"; > > > + VDDIO-supply = <®_vddio_codec>; > > > + VDDA-supply = <®_vdda_codec>; > > > + #sound-dai-cells = <0>; > > > + clocks = <&sys_mclk>; > > > + reg = <0x2a>; > > > + }; > > > + > > > + /* Current sensing circuit for 1V VDDCORE PMIC rail */ > > > + current-sensor@44 { > > > + compatible = "ti,ina220"; > > > + shunt-resistor = <1000>; > > > + reg = <0x44>; > > > + }; > > > + > > > + /* Current sensing circuit for 12V VCC rail */ > > > + current-sensor@45 { > > > + compatible = "ti,ina220"; > > > + shunt-resistor = <1000>; > > > + reg = <0x45>; > > > + }; > > > + > > > + /* Thermal monitor - case */ > > > + temperature-sensor@48 { > > > + compatible = "national,lm75"; > > > + reg = <0x48>; > > > + }; > > > + > > > + /* Thermal monitor - chip */ > > > + temperature-sensor@4c { > > > + compatible = "ti,tmp451"; > > > + reg = <0x4c>; > > > + }; > > > + > > > + eeprom@51 { > > > + compatible = "atmel,24c32"; > > > + reg = <0x51>; > > > + }; > > > + > > > + /* Unsupported devices: > > > + * - FXAS21002C Gyroscope at 0x20 > > > + * - TI ADS7924 4-channel ADC at 0x49 > > > + */ > > > +}; > > > + > > > +&qspi { > > > + status = "okay"; > > > + > > > + flash@0 { > > > + /* Rev. A uses 64MB flash, Rev. B & C use 32MB flash */ > > > + compatible = "jedec,spi-nor", "s25fl256s1", "s25fl512s"; > > > + spi-max-frequency = <20000000>; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + reg = <0>; > > > + > > > + partitions { > > > + compatible = "fixed-partitions"; > > > + #address-cells = <1>; > > > + #size-cells = <1>; > > > + > > > + partition@0 { > > > + label = "RCW"; > > > + reg = <0x0 0x40000>; > > > + }; > > > + > > > + partition@40000 { > > > + label = "U-Boot"; > > > + reg = <0x40000 0x300000>; > > > + }; > > > + > > > + partition@340000 { > > > + label = "U-Boot Env"; > > > + reg = <0x340000 0x100000>; > > > + }; > > > + }; > > > + }; > > > +}; > > > + > > > +&ifc { > > > > Please sort all these labelling nodes alphabetically. > > > > Hi Shawn, > > It's not entirely clear to me which nodes you mean. I should have put this comment at a better place, i.e. &dspi0 which breaks the order in the first place. &dspi0 { ... }; &enet0 { ... }; &enet1 { ... }; &enet2 { ... }; &esdhc { ... }; ... Shawn > > > > > + status = "disabled"; > > > +}; > > > + > > > +&esdhc { > > > + status = "okay"; > > > +}; > > > + > > > +&uart0 { > > > + status = "okay"; > > > +}; > > > + > > > +&lpuart0 { > > > + status = "okay"; > > > +}; > > > + > > > +&lpuart3 { > > > + status = "okay"; > > > +}; > > > + > > > +&sai2 { > > > + status = "okay"; > > > +}; > > > + > > > +&sata { > > > + status = "okay"; > > > +}; > > > -- > > > 2.17.1 > > >