From: Marcus Meissner <meissner@suse.de>
To: wmealing@redhat.com, blackgod016574@gmail.com, netdev@vger.kernel.org
Subject: Re: likely invalid CVE assignment for commit 95baa60a0da80a0143e3ddd4d3725758b4513825
Date: Thu, 6 Jun 2019 09:55:07 +0200 [thread overview]
Message-ID: <20190606075507.GA32166@suse.de> (raw)
In-Reply-To: <20190605092029.GB19508@suse.de>
Hi,
Dave does not like private-only emails, so again for netdev list:
On Wed, Jun 05, 2019 at 11:20:29AM +0200, Marcus Meissner wrote:
> Hi Gen Zhang,
>
> looking at https://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git/commit/?id=95baa60a0da80a0143e3ddd4d3725758b4513825
>
> ipv6_sockglue: Fix a missing-check bug in ip6_ra_control()
> In function ip6_ra_control(), the pointer new_ra is allocated a memory
> space via kmalloc(). And it is used in the following codes. However,
> when there is a memory allocation error, kmalloc() fails. Thus null
> pointer dereference may happen. And it will cause the kernel to crash.
> Therefore, we should check the return value and handle the error.
>
> There seems to be no case in current GIT where new_ra is being dereferenced even if it
> is NULL (kfree(NULL) will work fine).
>
> Was this just an assumption based on insufficient code review, or was there a real
> crash observed and how?
The reporter had replied privately that he was only doing a code audit.
We (Redhat and SUSE) wonder if this fix is needed at all.
Ciao, Marcus
next parent reply other threads:[~2019-06-06 7:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190605092029.GB19508@suse.de>
2019-06-06 7:55 ` Marcus Meissner [this message]
2019-06-06 8:06 ` likely invalid CVE assignment for commit 95baa60a0da80a0143e3ddd4d3725758b4513825 Gen Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606075507.GA32166@suse.de \
--to=meissner@suse.de \
--cc=blackgod016574@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=wmealing@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).