[PATCH iproute2-next] devlink: Increase bus,device buffer size to 64 bytes

[PATCH iproute2-next] devlink: Increase bus,device buffer size to 64 bytes

[Parav Pandit]

Device name on mdev bus is 36 characters long which follow standard uuid
RFC 4122.
This is probably the longest name that a kernel will return for a
device.

Hence increase the buffer size to 64 bytes.

Acked-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: Parav Pandit <parav@mellanox.com>

---
 devlink/devlink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/devlink/devlink.c b/devlink/devlink.c
index 436935f8..559f624e 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -1523,7 +1523,7 @@ static void __pr_out_handle_start(struct dl *dl, struct nlattr **tb,
 {
 	const char *bus_name = mnl_attr_get_str(tb[DEVLINK_ATTR_BUS_NAME]);
 	const char *dev_name = mnl_attr_get_str(tb[DEVLINK_ATTR_DEV_NAME]);
-	char buf[32];
+	char buf[64];
 
 	sprintf(buf, "%s/%s", bus_name, dev_name);
 
@@ -1616,7 +1616,7 @@ static void __pr_out_port_handle_start(struct dl *dl, const char *bus_name,
 				       uint32_t port_index, bool try_nice,
 				       bool array)
 {
-	static char buf[32];
+	static char buf[64];
 	char *ifname = NULL;
 
 	if (dl->no_nice_names || !try_nice ||
-- 
2.19.2

Re: [PATCH iproute2-next] devlink: Increase bus,device buffer size to 64 bytes

[Stephen Hemminger]

On Thu,  6 Jun 2019 06:49:19 -0500
Parav Pandit <parav@mellanox.com> wrote:

> Device name on mdev bus is 36 characters long which follow standard uuid
> RFC 4122.
> This is probably the longest name that a kernel will return for a
> device.
> 
> Hence increase the buffer size to 64 bytes.
> 
> Acked-by: Jiri Pirko <jiri@mellanox.com>
> Signed-off-by: Parav Pandit <parav@mellanox.com>
> 
> ---
>  devlink/devlink.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/devlink/devlink.c b/devlink/devlink.c
> index 436935f8..559f624e 100644
> --- a/devlink/devlink.c
> +++ b/devlink/devlink.c
> @@ -1523,7 +1523,7 @@ static void __pr_out_handle_start(struct dl *dl, struct nlattr **tb,
>  {
>  	const char *bus_name = mnl_attr_get_str(tb[DEVLINK_ATTR_BUS_NAME]);
>  	const char *dev_name = mnl_attr_get_str(tb[DEVLINK_ATTR_DEV_NAME]);
> -	char buf[32];
> +	char buf[64];
>  
>  	sprintf(buf, "%s/%s", bus_name, dev_name);
>  
> @@ -1616,7 +1616,7 @@ static void __pr_out_port_handle_start(struct dl *dl, const char *bus_name,
>  				       uint32_t port_index, bool try_nice,
>  				       bool array)
>  {
> -	static char buf[32];
> +	static char buf[64];
>  	char *ifname = NULL;
>  
>  	if (dl->no_nice_names || !try_nice ||

I will take this now no need to wait for next

RE: [PATCH iproute2-next] devlink: Increase bus,device buffer size to 64 bytes

[Parav Pandit]

> -----Original Message-----
> From: Stephen Hemminger <stephen@networkplumber.org>
> Sent: Thursday, June 6, 2019 8:49 PM
> To: Parav Pandit <parav@mellanox.com>
> Cc: dsahern@gmail.com; netdev@vger.kernel.org; Jiri Pirko
> <jiri@mellanox.com>
> Subject: Re: [PATCH iproute2-next] devlink: Increase bus,device buffer size to
> 64 bytes
> 
> On Thu,  6 Jun 2019 06:49:19 -0500
> Parav Pandit <parav@mellanox.com> wrote:
> 
> > Device name on mdev bus is 36 characters long which follow standard
> > uuid RFC 4122.
> > This is probably the longest name that a kernel will return for a
> > device.
> >
> > Hence increase the buffer size to 64 bytes.
> >
> > Acked-by: Jiri Pirko <jiri@mellanox.com>
> > Signed-off-by: Parav Pandit <parav@mellanox.com>
> >
> > ---
> >  devlink/devlink.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/devlink/devlink.c b/devlink/devlink.c index
> > 436935f8..559f624e 100644
> > --- a/devlink/devlink.c
> > +++ b/devlink/devlink.c
> > @@ -1523,7 +1523,7 @@ static void __pr_out_handle_start(struct dl *dl,
> > struct nlattr **tb,  {
> >  	const char *bus_name =
> mnl_attr_get_str(tb[DEVLINK_ATTR_BUS_NAME]);
> >  	const char *dev_name =
> mnl_attr_get_str(tb[DEVLINK_ATTR_DEV_NAME]);
> > -	char buf[32];
> > +	char buf[64];
> >
> >  	sprintf(buf, "%s/%s", bus_name, dev_name);
> >
> > @@ -1616,7 +1616,7 @@ static void __pr_out_port_handle_start(struct dl
> *dl, const char *bus_name,
> >  				       uint32_t port_index, bool try_nice,
> >  				       bool array)
> >  {
> > -	static char buf[32];
> > +	static char buf[64];
> >  	char *ifname = NULL;
> >
> >  	if (dl->no_nice_names || !try_nice ||
> 
> I will take this now no need to wait for next

Ok. thanks.