* [PATCH 5/8] drivers: media: coda: fix warning same module names @ 2019-06-06 9:47 Anders Roxell 2019-06-06 10:13 ` Hans Verkuil 0 siblings, 1 reply; 8+ messages in thread From: Anders Roxell @ 2019-06-06 9:47 UTC (permalink / raw) To: mchehab, p.zabel Cc: andrew, vivien.didelot, f.fainelli, marex, stefan, airlied, daniel, shawnguo, s.hauer, b.zolnierkie, a.hajda, hkallweit1, lee.jones, lgirdwood, broonie, davem, netdev, linux-kernel, dri-devel, linux-arm-kernel, linux-fbdev, linux-media, Anders Roxell When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as loadable modules, we see the following warning: warning: same module names found: fs/coda/coda.ko drivers/media/platform/coda/coda.ko Rework so media coda matches the config fragment. Leaving CODA_FS as is since thats a well known module. Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- drivers/media/platform/coda/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile index 54e9a73a92ab..588e6bf7c190 100644 --- a/drivers/media/platform/coda/Makefile +++ b/drivers/media/platform/coda/Makefile @@ -1,6 +1,6 @@ # SPDX-License-Identifier: GPL-2.0-only -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o -obj-$(CONFIG_VIDEO_CODA) += coda.o +obj-$(CONFIG_VIDEO_CODA) += video-coda.o obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o -- 2.20.1 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names 2019-06-06 9:47 [PATCH 5/8] drivers: media: coda: fix warning same module names Anders Roxell @ 2019-06-06 10:13 ` Hans Verkuil 2019-06-10 13:03 ` Anders Roxell 0 siblings, 1 reply; 8+ messages in thread From: Hans Verkuil @ 2019-06-06 10:13 UTC (permalink / raw) To: Anders Roxell, mchehab, p.zabel Cc: andrew, vivien.didelot, f.fainelli, marex, stefan, airlied, daniel, shawnguo, s.hauer, b.zolnierkie, a.hajda, hkallweit1, lee.jones, lgirdwood, broonie, davem, netdev, linux-kernel, dri-devel, linux-arm-kernel, linux-fbdev, linux-media On 6/6/19 11:47 AM, Anders Roxell wrote: > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as > loadable modules, we see the following warning: > > warning: same module names found: > fs/coda/coda.ko > drivers/media/platform/coda/coda.ko > > Rework so media coda matches the config fragment. Leaving CODA_FS as is > since thats a well known module. > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > drivers/media/platform/coda/Makefile | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile > index 54e9a73a92ab..588e6bf7c190 100644 > --- a/drivers/media/platform/coda/Makefile > +++ b/drivers/media/platform/coda/Makefile > @@ -1,6 +1,6 @@ > # SPDX-License-Identifier: GPL-2.0-only > > -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o > +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o > > -obj-$(CONFIG_VIDEO_CODA) += coda.o > +obj-$(CONFIG_VIDEO_CODA) += video-coda.o How about imx-coda? video-coda suggests it is part of the video subsystem, which it isn't. Regards, Hans > obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names 2019-06-06 10:13 ` Hans Verkuil @ 2019-06-10 13:03 ` Anders Roxell 2019-06-10 13:14 ` Matt Redfearn 0 siblings, 1 reply; 8+ messages in thread From: Anders Roxell @ 2019-06-10 13:03 UTC (permalink / raw) To: Hans Verkuil Cc: Mauro Carvalho Chehab, p.zabel, andrew, vivien.didelot, f.fainelli, marex, stefan, David Airlie, Daniel Vetter, shawnguo, s.hauer, b.zolnierkie, a.hajda, hkallweit1, Lee Jones, Liam Girdwood, Mark Brown, David Miller, Networking, Linux Kernel Mailing List, dri-devel, Linux ARM, linux-fbdev, linux-media On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote: > > On 6/6/19 11:47 AM, Anders Roxell wrote: > > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as > > loadable modules, we see the following warning: > > > > warning: same module names found: > > fs/coda/coda.ko > > drivers/media/platform/coda/coda.ko > > > > Rework so media coda matches the config fragment. Leaving CODA_FS as is > > since thats a well known module. > > > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > > --- > > drivers/media/platform/coda/Makefile | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile > > index 54e9a73a92ab..588e6bf7c190 100644 > > --- a/drivers/media/platform/coda/Makefile > > +++ b/drivers/media/platform/coda/Makefile > > @@ -1,6 +1,6 @@ > > # SPDX-License-Identifier: GPL-2.0-only > > > > -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o > > +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o > > > > -obj-$(CONFIG_VIDEO_CODA) += coda.o > > +obj-$(CONFIG_VIDEO_CODA) += video-coda.o > > How about imx-coda? video-coda suggests it is part of the video subsystem, > which it isn't. I'll resend a v2 shortly with imx-coda instead. Cheers, Anders > > Regards, > > Hans > > > obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names 2019-06-10 13:03 ` Anders Roxell @ 2019-06-10 13:14 ` Matt Redfearn 2019-06-11 8:15 ` Philipp Zabel 0 siblings, 1 reply; 8+ messages in thread From: Matt Redfearn @ 2019-06-10 13:14 UTC (permalink / raw) To: Anders Roxell, Hans Verkuil Cc: Mauro Carvalho Chehab, p.zabel@pengutronix.de, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, marex@denx.de, stefan@agner.ch, David Airlie, Daniel Vetter, shawnguo@kernel.org, s.hauer@pengutronix.de, b.zolnierkie@samsung.com, a.hajda@samsung.com, hkallweit1@gmail.com, Lee Jones, Liam Girdwood, Mark Brown, David Miller, Networking, Linux Kernel Mailing List, dri-devel, Linux ARM, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org On 10/06/2019 14:03, Anders Roxell wrote: > On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote: >> >> On 6/6/19 11:47 AM, Anders Roxell wrote: >>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as >>> loadable modules, we see the following warning: >>> >>> warning: same module names found: >>> fs/coda/coda.ko >>> drivers/media/platform/coda/coda.ko >>> >>> Rework so media coda matches the config fragment. Leaving CODA_FS as is >>> since thats a well known module. >>> >>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >>> --- >>> drivers/media/platform/coda/Makefile | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile >>> index 54e9a73a92ab..588e6bf7c190 100644 >>> --- a/drivers/media/platform/coda/Makefile >>> +++ b/drivers/media/platform/coda/Makefile >>> @@ -1,6 +1,6 @@ >>> # SPDX-License-Identifier: GPL-2.0-only >>> >>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o >>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o >>> >>> -obj-$(CONFIG_VIDEO_CODA) += coda.o >>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o >> >> How about imx-coda? video-coda suggests it is part of the video subsystem, >> which it isn't. > > I'll resend a v2 shortly with imx-coda instead. What about other vendor SoCs implementing the Coda IP block which are not an imx? I'd prefer a more generic name - maybe media-coda. Thanks, Matt > > > Cheers, > Anders > >> >> Regards, >> >> Hans >> >>> obj-$(CONFIG_VIDEO_IMX_VDOA) += imx-vdoa.o >>> >> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names 2019-06-10 13:14 ` Matt Redfearn @ 2019-06-11 8:15 ` Philipp Zabel 2019-06-11 8:21 ` Hans Verkuil 0 siblings, 1 reply; 8+ messages in thread From: Philipp Zabel @ 2019-06-11 8:15 UTC (permalink / raw) To: Matt Redfearn, Anders Roxell, Hans Verkuil Cc: Mauro Carvalho Chehab, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, marex@denx.de, stefan@agner.ch, David Airlie, Daniel Vetter, shawnguo@kernel.org, s.hauer@pengutronix.de, b.zolnierkie@samsung.com, a.hajda@samsung.com, hkallweit1@gmail.com, Lee Jones, Liam Girdwood, Mark Brown, David Miller, Networking, Linux Kernel Mailing List, dri-devel, Linux ARM, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org Hi, On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote: > > On 10/06/2019 14:03, Anders Roxell wrote: > > On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote: > > > > > > On 6/6/19 11:47 AM, Anders Roxell wrote: > > > > When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as > > > > loadable modules, we see the following warning: > > > > > > > > warning: same module names found: > > > > fs/coda/coda.ko > > > > drivers/media/platform/coda/coda.ko > > > > > > > > Rework so media coda matches the config fragment. Leaving CODA_FS as is > > > > since thats a well known module. > > > > > > > > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > > > > --- > > > > drivers/media/platform/coda/Makefile | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile > > > > index 54e9a73a92ab..588e6bf7c190 100644 > > > > --- a/drivers/media/platform/coda/Makefile > > > > +++ b/drivers/media/platform/coda/Makefile > > > > @@ -1,6 +1,6 @@ > > > > # SPDX-License-Identifier: GPL-2.0-only > > > > > > > > -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o > > > > +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o > > > > > > > > -obj-$(CONFIG_VIDEO_CODA) += coda.o > > > > +obj-$(CONFIG_VIDEO_CODA) += video-coda.o > > > > > > How about imx-coda? video-coda suggests it is part of the video subsystem, > > > which it isn't. > > > > I'll resend a v2 shortly with imx-coda instead. I'd be in favor of calling it "coda-vpu" instead. > What about other vendor SoCs implementing the Coda IP block which are > not an imx? I'd prefer a more generic name - maybe media-coda. Right, this driver can be used on other SoCs [1]. [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html regards Philipp ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names 2019-06-11 8:15 ` Philipp Zabel @ 2019-06-11 8:21 ` Hans Verkuil 2019-06-11 16:01 ` Anders Roxell 0 siblings, 1 reply; 8+ messages in thread From: Hans Verkuil @ 2019-06-11 8:21 UTC (permalink / raw) To: Philipp Zabel, Matt Redfearn, Anders Roxell Cc: Mauro Carvalho Chehab, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, marex@denx.de, stefan@agner.ch, David Airlie, Daniel Vetter, shawnguo@kernel.org, s.hauer@pengutronix.de, b.zolnierkie@samsung.com, a.hajda@samsung.com, hkallweit1@gmail.com, Lee Jones, Liam Girdwood, Mark Brown, David Miller, Networking, Linux Kernel Mailing List, dri-devel, Linux ARM, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org On 6/11/19 10:15 AM, Philipp Zabel wrote: > Hi, > > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote: >> >> On 10/06/2019 14:03, Anders Roxell wrote: >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote: >>>> >>>> On 6/6/19 11:47 AM, Anders Roxell wrote: >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as >>>>> loadable modules, we see the following warning: >>>>> >>>>> warning: same module names found: >>>>> fs/coda/coda.ko >>>>> drivers/media/platform/coda/coda.ko >>>>> >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is >>>>> since thats a well known module. >>>>> >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >>>>> --- >>>>> drivers/media/platform/coda/Makefile | 4 ++-- >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>>> >>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile >>>>> index 54e9a73a92ab..588e6bf7c190 100644 >>>>> --- a/drivers/media/platform/coda/Makefile >>>>> +++ b/drivers/media/platform/coda/Makefile >>>>> @@ -1,6 +1,6 @@ >>>>> # SPDX-License-Identifier: GPL-2.0-only >>>>> >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o >>>>> >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o >>>> >>>> How about imx-coda? video-coda suggests it is part of the video subsystem, >>>> which it isn't. >>> >>> I'll resend a v2 shortly with imx-coda instead. > > I'd be in favor of calling it "coda-vpu" instead. Fine by me! > >> What about other vendor SoCs implementing the Coda IP block which are >> not an imx? I'd prefer a more generic name - maybe media-coda. > > Right, this driver can be used on other SoCs [1]. Good point. Regards, Hans > > [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html > > regards > Philipp > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names 2019-06-11 8:21 ` Hans Verkuil @ 2019-06-11 16:01 ` Anders Roxell [not found] ` <CAAEAJfC9vja5WwsNc5+MTVHLFg_P3zG=OZt_CuRR5eG-3iWD9Q@mail.gmail.com> 0 siblings, 1 reply; 8+ messages in thread From: Anders Roxell @ 2019-06-11 16:01 UTC (permalink / raw) To: Hans Verkuil Cc: Philipp Zabel, Matt Redfearn, Mauro Carvalho Chehab, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, marex@denx.de, stefan@agner.ch, David Airlie, Daniel Vetter, shawnguo@kernel.org, s.hauer@pengutronix.de, b.zolnierkie@samsung.com, a.hajda@samsung.com, hkallweit1@gmail.com, Lee Jones, Liam Girdwood, Mark Brown, David Miller, Networking, Linux Kernel Mailing List, dri-devel, Linux ARM, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote: > > On 6/11/19 10:15 AM, Philipp Zabel wrote: > > Hi, > > > > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote: > >> > >> On 10/06/2019 14:03, Anders Roxell wrote: > >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote: > >>>> > >>>> On 6/6/19 11:47 AM, Anders Roxell wrote: > >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as > >>>>> loadable modules, we see the following warning: > >>>>> > >>>>> warning: same module names found: > >>>>> fs/coda/coda.ko > >>>>> drivers/media/platform/coda/coda.ko > >>>>> > >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is > >>>>> since thats a well known module. > >>>>> > >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > >>>>> --- > >>>>> drivers/media/platform/coda/Makefile | 4 ++-- > >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) > >>>>> > >>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile > >>>>> index 54e9a73a92ab..588e6bf7c190 100644 > >>>>> --- a/drivers/media/platform/coda/Makefile > >>>>> +++ b/drivers/media/platform/coda/Makefile > >>>>> @@ -1,6 +1,6 @@ > >>>>> # SPDX-License-Identifier: GPL-2.0-only > >>>>> > >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o > >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o > >>>>> > >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o > >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o > >>>> > >>>> How about imx-coda? video-coda suggests it is part of the video subsystem, > >>>> which it isn't. > >>> > >>> I'll resend a v2 shortly with imx-coda instead. > > > > I'd be in favor of calling it "coda-vpu" instead. > > Fine by me! > > > > >> What about other vendor SoCs implementing the Coda IP block which are > >> not an imx? I'd prefer a more generic name - maybe media-coda. > > > > Right, this driver can be used on other SoCs [1]. > > Good point. OK, so I'll change it to 'media-coda'. Cheers, Anders > > Regards, > > Hans > > > > > [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html > > > > regards > > Philipp > > > ^ permalink raw reply [flat|nested] 8+ messages in thread
[parent not found: <CAAEAJfC9vja5WwsNc5+MTVHLFg_P3zG=OZt_CuRR5eG-3iWD9Q@mail.gmail.com>]
* Re: [PATCH 5/8] drivers: media: coda: fix warning same module names [not found] ` <CAAEAJfC9vja5WwsNc5+MTVHLFg_P3zG=OZt_CuRR5eG-3iWD9Q@mail.gmail.com> @ 2019-06-11 16:28 ` Anders Roxell 0 siblings, 0 replies; 8+ messages in thread From: Anders Roxell @ 2019-06-11 16:28 UTC (permalink / raw) To: Ezequiel Garcia Cc: Hans Verkuil, Philipp Zabel, Matt Redfearn, Mauro Carvalho Chehab, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, marex@denx.de, stefan@agner.ch, David Airlie, Daniel Vetter, shawnguo@kernel.org, s.hauer@pengutronix.de, b.zolnierkie@samsung.com, a.hajda@samsung.com, hkallweit1@gmail.com, Lee Jones, Liam Girdwood, Mark Brown, David Miller, Networking, Linux Kernel Mailing List, dri-devel, Linux ARM, linux-fbdev@vger.kernel.org, linux-media@vger.kernel.org On Tue, 11 Jun 2019 at 18:18, Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> wrote: > > > > On Tue, Jun 11, 2019, 1:01 PM Anders Roxell <anders.roxell@linaro.org> wrote: >> >> On Tue, 11 Jun 2019 at 10:21, Hans Verkuil <hverkuil@xs4all.nl> wrote: >> > >> > On 6/11/19 10:15 AM, Philipp Zabel wrote: >> > > Hi, >> > > >> > > On Mon, 2019-06-10 at 13:14 +0000, Matt Redfearn wrote: >> > >> >> > >> On 10/06/2019 14:03, Anders Roxell wrote: >> > >>> On Thu, 6 Jun 2019 at 12:13, Hans Verkuil <hverkuil@xs4all.nl> wrote: >> > >>>> >> > >>>> On 6/6/19 11:47 AM, Anders Roxell wrote: >> > >>>>> When building with CONFIG_VIDEO_CODA and CONFIG_CODA_FS enabled as >> > >>>>> loadable modules, we see the following warning: >> > >>>>> >> > >>>>> warning: same module names found: >> > >>>>> fs/coda/coda.ko >> > >>>>> drivers/media/platform/coda/coda.ko >> > >>>>> >> > >>>>> Rework so media coda matches the config fragment. Leaving CODA_FS as is >> > >>>>> since thats a well known module. >> > >>>>> >> > >>>>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> > >>>>> --- >> > >>>>> drivers/media/platform/coda/Makefile | 4 ++-- >> > >>>>> 1 file changed, 2 insertions(+), 2 deletions(-) >> > >>>>> >> > >>>>> diff --git a/drivers/media/platform/coda/Makefile b/drivers/media/platform/coda/Makefile >> > >>>>> index 54e9a73a92ab..588e6bf7c190 100644 >> > >>>>> --- a/drivers/media/platform/coda/Makefile >> > >>>>> +++ b/drivers/media/platform/coda/Makefile >> > >>>>> @@ -1,6 +1,6 @@ >> > >>>>> # SPDX-License-Identifier: GPL-2.0-only >> > >>>>> >> > >>>>> -coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o >> > >>>>> +video-coda-objs := coda-common.o coda-bit.o coda-gdi.o coda-h264.o coda-mpeg2.o coda-mpeg4.o coda-jpeg.o >> > >>>>> >> > >>>>> -obj-$(CONFIG_VIDEO_CODA) += coda.o >> > >>>>> +obj-$(CONFIG_VIDEO_CODA) += video-coda.o >> > >>>> >> > >>>> How about imx-coda? video-coda suggests it is part of the video subsystem, >> > >>>> which it isn't. >> > >>> >> > >>> I'll resend a v2 shortly with imx-coda instead. >> > > >> > > I'd be in favor of calling it "coda-vpu" instead. >> > >> > Fine by me! >> > >> > > >> > >> What about other vendor SoCs implementing the Coda IP block which are >> > >> not an imx? I'd prefer a more generic name - maybe media-coda. >> > > >> > > Right, this driver can be used on other SoCs [1]. >> > >> > Good point. >> >> OK, so I'll change it to 'media-coda'. >> >> >> > > As suggested by Philipp, coda-vpu seems the most accurate name. urgh, that correct. Thanks, Anders > > Thanks, > Ezequiel > > > >> Cheers, >> Anders >> >> > >> > Regards, >> > >> > Hans >> > >> > > >> > > [1] https://www.mail-archive.com/linux-media@vger.kernel.org/msg146498.html >> > > >> > > regards >> > > Philipp >> > > >> > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-06-11 16:28 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-06 9:47 [PATCH 5/8] drivers: media: coda: fix warning same module names Anders Roxell
2019-06-06 10:13 ` Hans Verkuil
2019-06-10 13:03 ` Anders Roxell
2019-06-10 13:14 ` Matt Redfearn
2019-06-11 8:15 ` Philipp Zabel
2019-06-11 8:21 ` Hans Verkuil
2019-06-11 16:01 ` Anders Roxell
[not found] ` <CAAEAJfC9vja5WwsNc5+MTVHLFg_P3zG=OZt_CuRR5eG-3iWD9Q@mail.gmail.com>
2019-06-11 16:28 ` Anders Roxell
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).