From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: "Jubran, Samih" <sameehj@amazon.com>
Cc: David Woodhouse <dwmw2@infradead.org>,
"Bshara, Nafea" <nafea@amazon.com>, Andrew Lunn <andrew@lunn.ch>,
"Kiyanovski, Arthur" <akiyano@amazon.com>,
"Bshara, Saeed" <saeedb@amazon.com>,
"Tzalik, Guy" <gtzalik@amazon.com>,
"Matushevsky, Alexander" <matua@amazon.com>,
"Liguori, Anthony" <aliguori@amazon.com>,
"Saidi, Ali" <alisaidi@amazon.com>,
"Machulsky, Zorik" <zorik@amazon.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Wilson, Matt" <msw@amazon.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"Belgazal, Netanel" <netanel@amazon.com>,
"Herrenschmidt, Benjamin" <benh@amazon.com>
Subject: Re: [PATCH V2 net 00/11] Extending the ena driver to support new features and enhance performance
Date: Thu, 6 Jun 2019 10:16:34 -0700 [thread overview]
Message-ID: <20190606100945.49ceb657@cakuba.netronome.com> (raw)
In-Reply-To: <7f697af8f31f4bc7ba30ef643e7b3921@EX13D11EUB003.ant.amazon.com>
Hi Samih!
Please don't top post on Linux kernel mailing lists.
On Thu, 6 Jun 2019 10:23:40 +0000, Jubran, Samih wrote:
> As of today there are no flags exposed by ENA NIC device, however, we
> are planning to use them in the near future. We want to provide
> customers with extra methods to identify (and differentiate) multiple
> network interfaces that can be attached to a single VM. Currently,
> customers can identify a specific network interface (ENI) only by MAC
> address, and later look up this MAC among other multiple ENIs that
> they have. In some cases it might not be convenient. Using these
> flags will let us inform the customer about ENI`s specific
> properties.
Oh no :( You're using private _feature_ flags as labels or tags.
> It's not finalized, but tentatively it can look like this:
> primary-eni: on /* Differentiate between primary and secondary ENIs */
Did you consider using phys_port_name for this use case?
If the intent is to have those interfaces bonded, even better would
be to extend the net_failover module or work on user space ABI for VM
failover. That might be a bigger effort, though.
> has-associated-efa: on /* Will specify ENA device has another associated EFA device */
IDK how your ENA/EFA thing works, but sounds like something that should
be solved in the device model.
next prev parent reply other threads:[~2019-06-06 17:16 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 14:43 [PATCH V2 net 00/11] Extending the ena driver to support new features and enhance performance sameehj
2019-06-03 14:43 ` [PATCH V2 net 01/11] net: ena: add handling of llq max tx burst size sameehj
2019-06-03 14:43 ` [PATCH V2 net 02/11] net: ena: ethtool: add extra properties retrieval via get_priv_flags sameehj
2019-06-03 14:43 ` [PATCH V2 net 03/11] net: ena: replace free_tx/rx_ids union with single free_ids field in ena_ring sameehj
2019-06-03 14:43 ` [PATCH V2 net 04/11] net: ena: arrange ena_probe() function variables in reverse christmas tree sameehj
2019-06-03 14:43 ` [PATCH V2 net 05/11] net: ena: add newline at the end of pr_err prints sameehj
2019-06-03 14:43 ` [PATCH V2 net 06/11] net: ena: documentation: update ena.txt sameehj
2019-06-03 14:43 ` [PATCH V2 net 07/11] net: ena: allow automatic fallback to polling mode sameehj
2019-06-03 14:43 ` [PATCH V2 net 08/11] net: ena: add support for changing max_header_size in LLQ mode sameehj
2019-06-03 14:43 ` [PATCH V2 net 09/11] net: ena: optimise calculations for CQ doorbell sameehj
2019-06-03 14:43 ` [PATCH V2 net 10/11] net: ena: add good checksum counter sameehj
2019-06-03 14:43 ` [PATCH V2 net 11/11] net: ena: use dev_info_once instead of static variable sameehj
2019-06-03 20:30 ` [PATCH V2 net 00/11] Extending the ena driver to support new features and enhance performance David Miller
2019-06-03 21:32 ` Jakub Kicinski
[not found] ` <9da931e72debc868efaac144082f40d379c50f3c.camel@amazon.co.uk>
2019-06-03 23:03 ` Jakub Kicinski
2019-06-04 1:50 ` Andrew Lunn
2019-06-04 2:15 ` Bshara, Nafea
2019-06-04 6:57 ` David Woodhouse
2019-06-04 17:24 ` Jakub Kicinski
2019-06-06 10:23 ` Jubran, Samih
2019-06-06 17:16 ` Jakub Kicinski [this message]
2019-06-06 21:40 ` Bshara, Nafea
2019-06-06 22:04 ` Jakub Kicinski
2019-06-06 22:57 ` Bshara, Nafea
2019-06-06 23:07 ` Jakub Kicinski
2019-06-06 23:21 ` Bshara, Nafea
2019-06-06 23:42 ` Jakub Kicinski
2019-06-07 1:04 ` Bshara, Nafea
2019-06-07 1:14 ` Jakub Kicinski
2019-06-07 21:27 ` Jakub Kicinski
2019-06-07 21:34 ` Bshara, Nafea
2019-06-07 21:54 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190606100945.49ceb657@cakuba.netronome.com \
--to=jakub.kicinski@netronome.com \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=andrew@lunn.ch \
--cc=benh@amazon.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=gtzalik@amazon.com \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=sameehj@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).