From: Dan Carpenter <dan.carpenter@oracle.com>
To: David Ahern <dsahern@gmail.com>
Cc: David Ahern <dsahern@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH next] nexthop: off by one in nexthop_mpath_select()
Date: Fri, 7 Jun 2019 18:29:51 +0300 [thread overview]
Message-ID: <20190607152951.GR31203@kadam> (raw)
In-Reply-To: <0e02a744-f28e-e206-032b-a0ffac9f7311@gmail.com>
On Fri, Jun 07, 2019 at 08:54:33AM -0600, David Ahern wrote:
> On 6/7/19 7:56 AM, Dan Carpenter wrote:
> > The nhg->nh_entries[] array is allocated in nexthop_grp_alloc() and it
> > has nhg->num_nh elements so this check should be >= instead of >.
> >
> > Fixes: f88d8ea67fbd ("ipv6: Plumb support for nexthop object in a fib6_info")
>
> Wrong fixes. The helper was added by 430a049190de so it should be
>
> Fixes: 430a049190de ("nexthop: Add support for nexthop groups")
>
Sorry, my eyes must have gone squiffy. I don't even know how I got that
wrong. Let me resend.
regards,
dan carpenter
next prev parent reply other threads:[~2019-06-07 15:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-07 13:56 [PATCH next] nexthop: off by one in nexthop_mpath_select() Dan Carpenter
2019-06-07 14:54 ` David Ahern
2019-06-07 15:29 ` Dan Carpenter [this message]
2019-06-07 15:31 ` [PATCH v2 " Dan Carpenter
2019-06-09 20:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190607152951.GR31203@kadam \
--to=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dsahern@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).