* [PATCH v3 net-next] net: fec_main: Use dev_err() instead of pr_err()
@ 2019-06-07 12:14 Fabio Estevam
2019-06-09 20:32 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2019-06-07 12:14 UTC (permalink / raw)
To: davem; +Cc: fugang.duan, netdev, Fabio Estevam
dev_err() is more appropriate for printing error messages inside
drivers, so switch to dev_err().
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v2:
- Use dev_err() instead of netdev_err() - Andy
drivers/net/ethernet/freescale/fec_main.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 2ee72452ca76..9d459ccf251d 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2446,30 +2446,31 @@ static int
fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec)
{
struct fec_enet_private *fep = netdev_priv(ndev);
+ struct device *dev = &fep->pdev->dev;
unsigned int cycle;
if (!(fep->quirks & FEC_QUIRK_HAS_COALESCE))
return -EOPNOTSUPP;
if (ec->rx_max_coalesced_frames > 255) {
- pr_err("Rx coalesced frames exceed hardware limitation\n");
+ dev_err(dev, "Rx coalesced frames exceed hardware limitation\n");
return -EINVAL;
}
if (ec->tx_max_coalesced_frames > 255) {
- pr_err("Tx coalesced frame exceed hardware limitation\n");
+ dev_err(dev, "Tx coalesced frame exceed hardware limitation\n");
return -EINVAL;
}
cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr);
if (cycle > 0xFFFF) {
- pr_err("Rx coalesced usec exceed hardware limitation\n");
+ dev_err(dev, "Rx coalesced usec exceed hardware limitation\n");
return -EINVAL;
}
cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr);
if (cycle > 0xFFFF) {
- pr_err("Rx coalesced usec exceed hardware limitation\n");
+ dev_err(dev, "Rx coalesced usec exceed hardware limitation\n");
return -EINVAL;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3 net-next] net: fec_main: Use dev_err() instead of pr_err()
2019-06-07 12:14 [PATCH v3 net-next] net: fec_main: Use dev_err() instead of pr_err() Fabio Estevam
@ 2019-06-09 20:32 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-06-09 20:32 UTC (permalink / raw)
To: festevam; +Cc: fugang.duan, netdev
From: Fabio Estevam <festevam@gmail.com>
Date: Fri, 7 Jun 2019 09:14:18 -0300
> dev_err() is more appropriate for printing error messages inside
> drivers, so switch to dev_err().
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v2:
> - Use dev_err() instead of netdev_err() - Andy
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-09 20:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-07 12:14 [PATCH v3 net-next] net: fec_main: Use dev_err() instead of pr_err() Fabio Estevam
2019-06-09 20:32 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).