From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF6CEC28EBD for ; Sun, 9 Jun 2019 20:32:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6C43206BB for ; Sun, 9 Jun 2019 20:32:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729129AbfFIUcO (ORCPT ); Sun, 9 Jun 2019 16:32:14 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:45436 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbfFIUcO (ORCPT ); Sun, 9 Jun 2019 16:32:14 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id D3A6E14DF40D6; Sun, 9 Jun 2019 13:32:13 -0700 (PDT) Date: Sun, 09 Jun 2019 13:32:13 -0700 (PDT) Message-Id: <20190609.133213.127991801665240939.davem@davemloft.net> To: festevam@gmail.com Cc: fugang.duan@nxp.com, netdev@vger.kernel.org Subject: Re: [PATCH v3 net-next] net: fec_main: Use dev_err() instead of pr_err() From: David Miller In-Reply-To: <20190607121418.16760-1-festevam@gmail.com> References: <20190607121418.16760-1-festevam@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 09 Jun 2019 13:32:14 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Fabio Estevam Date: Fri, 7 Jun 2019 09:14:18 -0300 > dev_err() is more appropriate for printing error messages inside > drivers, so switch to dev_err(). > > Signed-off-by: Fabio Estevam > --- > Changes since v2: > - Use dev_err() instead of netdev_err() - Andy Applied.