From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B292FC28EBD for ; Sun, 9 Jun 2019 20:38:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8D2DA206C3 for ; Sun, 9 Jun 2019 20:38:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729905AbfFIUiI (ORCPT ); Sun, 9 Jun 2019 16:38:08 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:45532 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725933AbfFIUiI (ORCPT ); Sun, 9 Jun 2019 16:38:08 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id B7F5E14DF3D4F; Sun, 9 Jun 2019 13:38:07 -0700 (PDT) Date: Sun, 09 Jun 2019 13:38:07 -0700 (PDT) Message-Id: <20190609.133807.1807112771773489916.davem@davemloft.net> To: dan.carpenter@oracle.com Cc: dsahern@kernel.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH v2 next] nexthop: off by one in nexthop_mpath_select() From: David Miller In-Reply-To: <20190607153107.GS31203@kadam> References: <0e02a744-f28e-e206-032b-a0ffac9f7311@gmail.com> <20190607153107.GS31203@kadam> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 09 Jun 2019 13:38:07 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Dan Carpenter Date: Fri, 7 Jun 2019 18:31:07 +0300 > The nhg->nh_entries[] array is allocated in nexthop_grp_alloc() and it > has nhg->num_nh elements so this check should be >= instead of >. > > Fixes: 430a049190de ("nexthop: Add support for nexthop groups") > Signed-off-by: Dan Carpenter > Reviewed-by: David Ahern > --- > v2: Use the correct Fixes tag Applied, thanks Dan.