From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF64CC28EBD for ; Mon, 10 Jun 2019 02:54:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D2AC420820 for ; Mon, 10 Jun 2019 02:54:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387479AbfFJCyW (ORCPT ); Sun, 9 Jun 2019 22:54:22 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:48896 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387400AbfFJCyW (ORCPT ); Sun, 9 Jun 2019 22:54:22 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5BE0114EADFBE; Sun, 9 Jun 2019 19:54:21 -0700 (PDT) Date: Sun, 09 Jun 2019 19:54:20 -0700 (PDT) Message-Id: <20190609.195420.1742255944804133266.davem@davemloft.net> To: hariprasad.kelam@gmail.com Cc: kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipv6: exthdrs: fix warning comparison to bool From: David Miller In-Reply-To: <20190608083532.GA7288@hari-Inspiron-1545> References: <20190608083532.GA7288@hari-Inspiron-1545> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 09 Jun 2019 19:54:21 -0700 (PDT) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Hariprasad Kelam Date: Sat, 8 Jun 2019 14:05:33 +0530 > Fix below warning reported by coccicheck > > net/ipv6/exthdrs.c:180:9-29: WARNING: Comparison to bool > > Signed-off-by: Hariprasad Kelam ... > diff --git a/net/ipv6/exthdrs.c b/net/ipv6/exthdrs.c > index ab5add0..e137325 100644 > --- a/net/ipv6/exthdrs.c > +++ b/net/ipv6/exthdrs.c > @@ -177,7 +177,7 @@ static bool ip6_parse_tlv(const struct tlvtype_proc *procs, > /* type specific length/alignment > checks will be performed in the > func(). */ > - if (curr->func(skb, off) == false) > + if (!curr->func(skb, off)) curr->func() returns type 'bool', whats wrong with comparing against the same type? I'm not applying stuff like this, sorry.