From: David Miller <davem@davemloft.net>
To: hariprasad.kelam@gmail.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nfc: nci: fix warning comparison to bool
Date: Sun, 09 Jun 2019 19:55:00 -0700 (PDT) [thread overview]
Message-ID: <20190609.195500.2162257859838379859.davem@davemloft.net> (raw)
In-Reply-To: <20190608084154.GA7520@hari-Inspiron-1545>
From: Hariprasad Kelam <hariprasad.kelam@gmail.com>
Date: Sat, 8 Jun 2019 14:11:54 +0530
> Fix below warning reported by coccicheck
>
> net/nfc/nci/ntf.c:367:5-15: WARNING: Comparison to bool
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> net/nfc/nci/ntf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/nfc/nci/ntf.c b/net/nfc/nci/ntf.c
> index 1e8c1a1..81e8570 100644
> --- a/net/nfc/nci/ntf.c
> +++ b/net/nfc/nci/ntf.c
> @@ -364,7 +364,7 @@ static void nci_rf_discover_ntf_packet(struct nci_dev *ndev,
> ntf.ntf_type = *data++;
> pr_debug("ntf_type %d\n", ntf.ntf_type);
>
> - if (add_target == true)
> + if (add_target)
add_target is a bool, these kinds of changes are not good.
prev parent reply other threads:[~2019-06-10 2:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 8:41 [PATCH] nfc: nci: fix warning comparison to bool Hariprasad Kelam
2019-06-10 2:55 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190609.195500.2162257859838379859.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=hariprasad.kelam@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox