From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 81701C28EBD for ; Sun, 9 Jun 2019 10:59:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B07120840 for ; Sun, 9 Jun 2019 10:59:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560077960; bh=rwSR3o1mv7zWnCRQ7zDWKuYNCzMiZtQnKYlpzI1SHOA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=AJb6s7dfiGhd7hEo2FxL5OW/RwVrNGqjoBs4rJJ//2xwFCRQl35E75n26lCk8kLRs ZNedT68BHlbHlk/v/7AV0YoHOBsnw9xIeHAIl0XUgoYN0Eq9D1a2CMMw6gYoLY0px/ znt3pH5Vx2nzIjYBG7UQFVay50QxZbew0iXa9II0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728134AbfFIK7T (ORCPT ); Sun, 9 Jun 2019 06:59:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:39016 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728029AbfFIK7S (ORCPT ); Sun, 9 Jun 2019 06:59:18 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C19FD2083D; Sun, 9 Jun 2019 10:59:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560077958; bh=rwSR3o1mv7zWnCRQ7zDWKuYNCzMiZtQnKYlpzI1SHOA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fa586/Nq76fAtEB8nXsQvlJD11gR/Z7mszDYU5HMV9dfRfItXyaUpLfMgfvt4tG3C 5iZpQxmdpLGyXXZfXYkNwZxEKshPryB2lpBGJldouR7i0KKGUYyIzg2NzgdxbBLYu2 SH76ke4aksII0NxvnGqEuIlrFrBgcnmL5Oc0ZgrQ= Date: Sun, 9 Jun 2019 12:59:09 +0200 From: "gregkh@linuxfoundation.org" To: Rishiraj Manwatkar Cc: "isdn@linux-pingi.de" , "arnd@arndb.de" , "netdev@vger.kernel.org" , "devel@driverdev.osuosl.org" Subject: Re: [PATCH] staging: isdn: To make hysdn_proc_entry static. Message-ID: <20190609105909.GA30671@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.0 (2019-05-25) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jun 09, 2019 at 12:24:59AM +0000, Rishiraj Manwatkar wrote: > Made hysdn_proc_entry static as suggested by Sparse tool. Why is this indented? > > Signed-off-by: Rishiraj Manwatkar > --- > drivers/staging/isdn/hysdn/hysdn_procconf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/isdn/hysdn/hysdn_procconf.c b/drivers/staging/isdn/hysdn/hysdn_procconf.c > index 73079213ec94..3d12c058a6f1 100644 > --- a/drivers/staging/isdn/hysdn/hysdn_procconf.c > +++ b/drivers/staging/isdn/hysdn/hysdn_procconf.c > @@ -349,7 +349,7 @@ static const struct file_operations conf_fops = > /*****************************/ > /* hysdn subdir in /proc/net */ > /*****************************/ > -struct proc_dir_entry *hysdn_proc_entry = NULL; > +static struct proc_dir_entry *hysdn_proc_entry = NULL; I will have to wait until after 5.3-rc1 before taking any drivers/staging/isdn patches, sorry. I suggest waiting until then before resending, and even then, the isdn code is about to be deleted, try working on code that is being accepted. thanks, greg k-h