* Re: [PATCH] staging: isdn: To make hysdn_proc_entry static.
[not found] <VE1PR09MB31685C49AD00EC2206C471E5A4120@VE1PR09MB3168.eurprd09.prod.outlook.com>
@ 2019-06-09 10:59 ` gregkh
0 siblings, 0 replies; only message in thread
From: gregkh @ 2019-06-09 10:59 UTC (permalink / raw)
To: Rishiraj Manwatkar
Cc: isdn@linux-pingi.de, arnd@arndb.de, netdev@vger.kernel.org,
devel@driverdev.osuosl.org
On Sun, Jun 09, 2019 at 12:24:59AM +0000, Rishiraj Manwatkar wrote:
> Made hysdn_proc_entry static as suggested by Sparse tool.
Why is this indented?
>
> Signed-off-by: Rishiraj Manwatkar <manwatkar@outlook.com>
> ---
> drivers/staging/isdn/hysdn/hysdn_procconf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/isdn/hysdn/hysdn_procconf.c b/drivers/staging/isdn/hysdn/hysdn_procconf.c
> index 73079213ec94..3d12c058a6f1 100644
> --- a/drivers/staging/isdn/hysdn/hysdn_procconf.c
> +++ b/drivers/staging/isdn/hysdn/hysdn_procconf.c
> @@ -349,7 +349,7 @@ static const struct file_operations conf_fops =
> /*****************************/
> /* hysdn subdir in /proc/net */
> /*****************************/
> -struct proc_dir_entry *hysdn_proc_entry = NULL;
> +static struct proc_dir_entry *hysdn_proc_entry = NULL;
I will have to wait until after 5.3-rc1 before taking any
drivers/staging/isdn patches, sorry.
I suggest waiting until then before resending, and even then, the isdn
code is about to be deleted, try working on code that is being accepted.
thanks,
greg k-h
^ permalink raw reply [flat|nested] only message in thread