From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=S7Fl=UJ=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 0117CC31E41
	for <netdev@archiver.kernel.org>; Mon, 10 Jun 2019 16:06:07 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id D76B220820
	for <netdev@archiver.kernel.org>; Mon, 10 Jun 2019 16:06:06 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2391443AbfFJQGF (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 10 Jun 2019 12:06:05 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:57678 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2391437AbfFJQGD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 10 Jun 2019 12:06:03 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id D0A9C15050C72;
        Mon, 10 Jun 2019 09:06:02 -0700 (PDT)
Date:   Mon, 10 Jun 2019 09:06:02 -0700 (PDT)
Message-Id: <20190610.090602.2001139990603847705.davem@davemloft.net>
To:     jian.w.wen@oracle.com
Cc:     netdev@vger.kernel.org, john.r.fastabend@intel.com
Subject: Re: [PATCH net] net_sched: sch_mqprio: handle return value of
 mqprio_queue_get
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190610.090526.1763320783297544794.davem@davemloft.net>
References: <20190610063821.27007-1-jian.w.wen@oracle.com>
        <20190610.090526.1763320783297544794.davem@davemloft.net>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 10 Jun 2019 09:06:03 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: David Miller <davem@davemloft.net>
Date: Mon, 10 Jun 2019 09:05:26 -0700 (PDT)

> From: Jacob Wen <jian.w.wen@oracle.com>
> Date: Mon, 10 Jun 2019 14:38:21 +0800
> 
>> It may return NULL thus we can't ignore it.
> 
> Please repost with a proper signoff.

Also, you are breaking the reverse christmas tree ordering of the local
variables with your change.  Please do not do that.