From: Stephen Hemminger <stephen@networkplumber.org>
To: Mahesh Bandewar <maheshb@google.com>
Cc: Mahesh Bandewar <mahesh@bandewar.net>, Netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2] ip6tunnel: fix 'ip -6 {show|change} dev <name>' cmds
Date: Mon, 10 Jun 2019 10:48:21 -0700 [thread overview]
Message-ID: <20190610104821.0a7c6b8a@hermes.lan> (raw)
In-Reply-To: <20190606234426.208019-1-maheshb@google.com>
On Thu, 6 Jun 2019 16:44:26 -0700
Mahesh Bandewar <maheshb@google.com> wrote:
> Inclusion of 'dev' is allowed by the syntax but not handled
> correctly by the command. It produces no output for show
> command and falsely successful for change command but does
> not make any changes.
>
> can be verified with the following steps
> # ip -6 tunnel add ip6tnl1 mode ip6gre local fd::1 remote fd::2 tos inherit ttl 127 encaplimit none
> # ip -6 tunnel show ip6tnl1
> <correct output>
> # ip -6 tunnel show dev ip6tnl1
> <no output but correct output after this change>
> # ip -6 tunnel change dev ip6tnl1 local 2001:1234::1 remote 2001:1234::2 encaplimit none ttl 127 tos inherit allow-localremote
> # echo $?
> 0
> # ip -6 tunnel show ip6tnl1
> <no changes applied, but changes are correctly applied after this change>
>
> Signed-off-by: Mahesh Bandewar <maheshb@google.com>
Applied, thanks.
prev parent reply other threads:[~2019-06-10 17:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-06 23:44 [PATCH iproute2] ip6tunnel: fix 'ip -6 {show|change} dev <name>' cmds Mahesh Bandewar
2019-06-10 17:48 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610104821.0a7c6b8a@hermes.lan \
--to=stephen@networkplumber.org \
--cc=mahesh@bandewar.net \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).