netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ido Schimmel <idosch@idosch.org>
To: Andrew Lunn <andrew@lunn.ch>
Cc: davem@davemloft.net, netdev@vger.kernel.org, amitc@mellanox.com,
	mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test
Date: Mon, 10 Jun 2019 16:58:48 +0300	[thread overview]
Message-ID: <20190610135848.GB19495@splinter> (raw)
In-Reply-To: <20190610134820.GG8247@lunn.ch>

On Mon, Jun 10, 2019 at 03:48:20PM +0200, Andrew Lunn wrote:
> > +		# Skip 56G because this speed isn't supported with autoneg off.
> > +		if [[ $speed == 56000 ]]; then
> > +			continue
> > +		fi
> 
> Interesting. How is 56000 represented in ethtool? Listed in both
> "Supported link modes" and "Advertised link modes"?

Hi Andrew,

Yes. We recently sent a patch to error out if autoneg is off: Commit
275e928f1911 ("mlxsw: spectrum: Prevent force of 56G").

  reply	other threads:[~2019-06-10 13:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-10  8:40 [PATCH net-next 0/3] mlxsw: Add speed and auto-negotiation test Ido Schimmel
2019-06-10  8:40 ` [PATCH net-next 1/3] selftests: mlxsw: Add ethtool_lib.sh Ido Schimmel
2019-06-10 13:35   ` Andrew Lunn
2019-06-10 13:56     ` Ido Schimmel
2019-06-10 15:29       ` Florian Fainelli
2019-06-11  6:51         ` Ido Schimmel
2019-06-10 13:59   ` Andrew Lunn
2019-06-10 14:31     ` Ido Schimmel
2019-06-10 14:51       ` Andrew Lunn
2019-06-10  8:40 ` [PATCH net-next 2/3] selftests: mlxsw: lib.sh: Add wait for dev with timeout Ido Schimmel
2019-06-10  8:40 ` [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test Ido Schimmel
2019-06-10 13:48   ` Andrew Lunn
2019-06-10 13:58     ` Ido Schimmel [this message]
2019-06-10 14:06       ` Andrew Lunn
2019-06-11  6:35         ` Ido Schimmel
2019-06-11 12:22           ` Andrew Lunn
2019-06-11 13:06             ` Ido Schimmel
2019-06-11 13:30               ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190610135848.GB19495@splinter \
    --to=idosch@idosch.org \
    --cc=amitc@mellanox.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=idosch@mellanox.com \
    --cc=mlxsw@mellanox.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).