From: Andrew Lunn <andrew@lunn.ch>
To: Ido Schimmel <idosch@idosch.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, amitc@mellanox.com,
mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 1/3] selftests: mlxsw: Add ethtool_lib.sh
Date: Mon, 10 Jun 2019 16:51:03 +0200 [thread overview]
Message-ID: <20190610145103.GI28724@lunn.ch> (raw)
In-Reply-To: <20190610143157.GA20333@splinter>
> Andrew, are you suggestion to split speeds_get() into
> supported_speeds_get() and advertised_speeds_get() and use each where
> appropriate? Note that not all the tests are testing with autoneg on.
Hi Ido
Yes.
You should be able to force all speeds in supported speeds. But if you
try to auto-neg an speed which is not listed in advertised speeds when
all are enabled, i would expect an error.
Andrew
next prev parent reply other threads:[~2019-06-10 14:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 8:40 [PATCH net-next 0/3] mlxsw: Add speed and auto-negotiation test Ido Schimmel
2019-06-10 8:40 ` [PATCH net-next 1/3] selftests: mlxsw: Add ethtool_lib.sh Ido Schimmel
2019-06-10 13:35 ` Andrew Lunn
2019-06-10 13:56 ` Ido Schimmel
2019-06-10 15:29 ` Florian Fainelli
2019-06-11 6:51 ` Ido Schimmel
2019-06-10 13:59 ` Andrew Lunn
2019-06-10 14:31 ` Ido Schimmel
2019-06-10 14:51 ` Andrew Lunn [this message]
2019-06-10 8:40 ` [PATCH net-next 2/3] selftests: mlxsw: lib.sh: Add wait for dev with timeout Ido Schimmel
2019-06-10 8:40 ` [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test Ido Schimmel
2019-06-10 13:48 ` Andrew Lunn
2019-06-10 13:58 ` Ido Schimmel
2019-06-10 14:06 ` Andrew Lunn
2019-06-11 6:35 ` Ido Schimmel
2019-06-11 12:22 ` Andrew Lunn
2019-06-11 13:06 ` Ido Schimmel
2019-06-11 13:30 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610145103.GI28724@lunn.ch \
--to=andrew@lunn.ch \
--cc=amitc@mellanox.com \
--cc=davem@davemloft.net \
--cc=idosch@idosch.org \
--cc=idosch@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).