From: "Björn Töpel" <bjorn.topel@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net, netdev@vger.kernel.org
Cc: "Björn Töpel" <bjorn.topel@gmail.com>,
magnus.karlsson@intel.com, bjorn.topel@intel.com,
toke@redhat.com, brouer@redhat.com, bpf@vger.kernel.org,
jakub.kicinski@netronome.com, saeedm@mellanox.com
Subject: [PATCH bpf-next v3 0/5] net: xdp: refactor XDP program queries
Date: Mon, 10 Jun 2019 18:02:29 +0200 [thread overview]
Message-ID: <20190610160234.4070-1-bjorn.topel@gmail.com> (raw)
Here's yet another attempt tomove the XDP_QUERY_PROG{,_HW} code out
from the drivers to generic netdev code.
I took a bit different approach with the v3. In this revision I
introduced to a new netdev_xdp structure that tracks the XDP programs,
and instead of sharing the xdp_prog member between DRV and SKB (again,
they mutual exclusive). With this, there's no need for a special
"what-mode-am-I-in" flag for SKB/DRV.
Jakub, what's your thoughts on the special handling of XDP offloading?
Maybe it's just overkill? Just allocate space for the offloaded
program regardless support or not? Also, please review the
dev_xdp_support_offload() addition into the nfp code.
The last two patches move the attach flag checks to generic code, and
removes the flags member from netdev_bpf.
Please refer to the individual commit messages for more details.
The series passes test_offload.py from selftests. Thanks to Jakub for
pointing this out.
Thanks,
Björn
Björn Töpel (5):
net: xdp: refactor XDP_QUERY_PROG{,_HW} to netdev
nfp, netdevsim: use dev_xdp_support_offload() function
net: xdp: remove XDP_QUERY_PROG{,_HW}
net: xdp: refactor XDP flags checking
net: xdp: remove xdp_attachment_flags_ok() and flags member
drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c | 4 -
.../net/ethernet/cavium/thunder/nicvf_main.c | 3 -
.../net/ethernet/freescale/dpaa2/dpaa2-eth.c | 3 -
drivers/net/ethernet/intel/i40e/i40e_main.c | 3 -
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 -
.../net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 -
.../net/ethernet/mellanox/mlx4/en_netdev.c | 24 ---
.../net/ethernet/mellanox/mlx5/core/en_main.c | 18 --
.../ethernet/netronome/nfp/nfp_net_common.c | 10 -
.../net/ethernet/netronome/nfp/nfp_net_main.c | 7 +
.../net/ethernet/qlogic/qede/qede_filter.c | 3 -
drivers/net/netdevsim/bpf.c | 7 -
drivers/net/netdevsim/netdev.c | 4 +
drivers/net/netdevsim/netdevsim.h | 2 +-
drivers/net/tun.c | 15 --
drivers/net/veth.c | 15 --
drivers/net/virtio_net.c | 17 --
include/linux/netdevice.h | 30 +--
include/net/xdp.h | 5 -
net/core/dev.c | 172 ++++++++++++------
net/core/rtnetlink.c | 31 +---
net/core/xdp.c | 22 ---
22 files changed, 147 insertions(+), 256 deletions(-)
--
2.20.1
next reply other threads:[~2019-06-10 16:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 16:02 Björn Töpel [this message]
2019-06-10 16:02 ` [PATCH bpf-next v3 1/5] net: xdp: refactor XDP_QUERY_PROG{,_HW} to netdev Björn Töpel
2019-06-10 16:02 ` [PATCH bpf-next v3 2/5] nfp, netdevsim: use dev_xdp_support_offload() function Björn Töpel
2019-06-10 16:02 ` [PATCH bpf-next v3 3/5] net: xdp: remove XDP_QUERY_PROG{,_HW} Björn Töpel
2019-06-10 16:02 ` [PATCH bpf-next v3 4/5] net: xdp: refactor XDP flags checking Björn Töpel
2019-06-10 16:02 ` [PATCH bpf-next v3 5/5] net: xdp: remove xdp_attachment_flags_ok() and flags member Björn Töpel
2019-06-10 22:24 ` [PATCH bpf-next v3 0/5] net: xdp: refactor XDP program queries Jakub Kicinski
2019-06-11 7:24 ` Björn Töpel
2019-06-11 12:17 ` Toke Høiland-Jørgensen
2019-06-11 17:22 ` Jakub Kicinski
2019-06-12 5:38 ` Björn Töpel
2019-06-12 14:31 ` Jonathan Lemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610160234.4070-1-bjorn.topel@gmail.com \
--to=bjorn.topel@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=jakub.kicinski@netronome.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).