From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B46CC4321A for ; Mon, 10 Jun 2019 21:15:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 00F1120859 for ; Mon, 10 Jun 2019 21:15:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="J3D/nqze" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389836AbfFJVPj (ORCPT ); Mon, 10 Jun 2019 17:15:39 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:42940 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726528AbfFJVPj (ORCPT ); Mon, 10 Jun 2019 17:15:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kOvoZ7UUXPPjS3T4n7Fk8hqSwFzI6Ebfl9pCSW6cL+U=; b=J3D/nqzeZzV1Sa+tPzjwVjYB9y zN5/zbXSUI8DL3H5WZov4uMPwePt+tbWv232sfGP1gZXcZFqURQACVG65vKN4lE0U9iXIRmz4wmQK R5+7zwafOcVxXa4Vv2+XEIvQXd2WILnODeH/GMyZ/M2IWac01+73EchMisz012M0Xnag=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1haRde-000217-DP; Mon, 10 Jun 2019 23:15:34 +0200 Date: Mon, 10 Jun 2019 23:15:34 +0200 From: Andrew Lunn To: Florian Fainelli Cc: netdev@vger.kernel.org, ioana.ciornei@nxp.com, olteanv@gmail.com, rmk+kernel@armlinux.org.uk, Vivien Didelot , "David S. Miller" , open list Subject: Re: [PATCH net-next] net: dsa: Deal with non-existing PHY/fixed-link Message-ID: <20190610211534.GD2191@lunn.ch> References: <20190610193150.22231-1-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190610193150.22231-1-f.fainelli@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 10, 2019 at 12:31:49PM -0700, Florian Fainelli wrote: > We need to specifically deal with phylink_of_phy_connect() returning > -ENODEV, because this can happen when a CPU/DSA port does connect > neither to a PHY, nor has a fixed-link property. This is a valid use > case that is permitted by the binding and indicates to the switch: > auto-configure port with maximum capabilities. > > Fixes: 0e27921816ad ("net: dsa: Use PHYLINK for the CPU/DSA ports") > Signed-off-by: Florian Fainelli Hi Florian This fixes the regression. Reviewed-by: Andrew Lunn But i wonder if we want to add in (dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port) i.e. force a user port to have some form of PHY? Andrew