From: Stephen Suryaputra <ssuryaextr@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: gvaradar@cisco.com, benve@cisco.com, netdev@vger.kernel.org,
govind.varadar@gmail.com
Subject: Re: [PATCH net] net: handle 802.1P vlan 0 packets properly
Date: Mon, 10 Jun 2019 19:08:36 -0400 [thread overview]
Message-ID: <20190610230836.GA3390@ubuntu> (raw)
In-Reply-To: <20190610.142810.138225058759413106.davem@davemloft.net>
On Mon, Jun 10, 2019 at 02:28:10PM -0700, David Miller wrote:
> From: Govindarajulu Varadarajan <gvaradar@cisco.com>
> Date: Mon, 10 Jun 2019 07:27:02 -0700
>
> > When stack receives pkt: [802.1P vlan 0][802.1AD vlan 100][IPv4],
> > vlan_do_receive() returns false if it does not find vlan_dev. Later
> > __netif_receive_skb_core() fails to find packet type handler for
> > skb->protocol 801.1AD and drops the packet.
> >
> > 801.1P header with vlan id 0 should be handled as untagged packets.
> > This patch fixes it by checking if vlan_id is 0 and processes next vlan
> > header.
> >
> > Signed-off-by: Govindarajulu Varadarajan <gvaradar@cisco.com>
>
> Under Linux we absolutely do not decapsulate the VLAN protocol unless
> a VLAN device is configured on that interface.
VLAN ID 0 is treated as if the VLAN protocol isn't there. It is used so
that the 802.1 priority bits can be encoded and acted upon.
next prev parent reply other threads:[~2019-06-10 23:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 14:27 [PATCH net] net: handle 802.1P vlan 0 packets properly Govindarajulu Varadarajan
2019-06-10 21:28 ` David Miller
2019-06-10 23:08 ` Stephen Suryaputra [this message]
2019-06-11 0:35 ` Christian Benvenuti (benve)
2019-06-11 1:20 ` David Miller
2019-06-10 23:09 ` Govindarajulu Varadarajan (gvaradar)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190610230836.GA3390@ubuntu \
--to=ssuryaextr@gmail.com \
--cc=benve@cisco.com \
--cc=davem@davemloft.net \
--cc=govind.varadar@gmail.com \
--cc=gvaradar@cisco.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).