* [PATCH net-next] net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del()
@ 2019-06-09 17:19 Taehee Yoo
2019-06-10 21:13 ` [ovs-dev] " Gregory Rose
2019-06-11 18:56 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Taehee Yoo @ 2019-06-09 17:19 UTC (permalink / raw)
To: davem, pshelar, netdev, dev; +Cc: ap420073
ASSERT_OVSL() in ovs_vport_del() is unnecessary because
ovs_vport_del() is only called by ovs_dp_detach_port() and
ovs_dp_detach_port() calls ASSERT_OVSL() too.
Signed-off-by: Taehee Yoo <ap420073@gmail.com>
---
net/openvswitch/vport.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 258ce3b7b452..9e71f1a601a9 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c
@@ -261,8 +261,6 @@ int ovs_vport_set_options(struct vport *vport, struct nlattr *options)
*/
void ovs_vport_del(struct vport *vport)
{
- ASSERT_OVSL();
-
hlist_del_rcu(&vport->hash_node);
module_put(vport->ops->owner);
vport->ops->destroy(vport);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [ovs-dev] [PATCH net-next] net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del()
2019-06-09 17:19 [PATCH net-next] net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del() Taehee Yoo
@ 2019-06-10 21:13 ` Gregory Rose
2019-06-11 18:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Gregory Rose @ 2019-06-10 21:13 UTC (permalink / raw)
To: Taehee Yoo, davem, pshelar, netdev, dev
On 6/9/2019 10:19 AM, Taehee Yoo wrote:
> ASSERT_OVSL() in ovs_vport_del() is unnecessary because
> ovs_vport_del() is only called by ovs_dp_detach_port() and
> ovs_dp_detach_port() calls ASSERT_OVSL() too.
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
> ---
> net/openvswitch/vport.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
> index 258ce3b7b452..9e71f1a601a9 100644
> --- a/net/openvswitch/vport.c
> +++ b/net/openvswitch/vport.c
> @@ -261,8 +261,6 @@ int ovs_vport_set_options(struct vport *vport, struct nlattr *options)
> */
> void ovs_vport_del(struct vport *vport)
> {
> - ASSERT_OVSL();
> -
> hlist_del_rcu(&vport->hash_node);
> module_put(vport->ops->owner);
> vport->ops->destroy(vport);
LGTM
Reviewed-by: Greg Rose <gvrose8192@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del()
2019-06-09 17:19 [PATCH net-next] net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del() Taehee Yoo
2019-06-10 21:13 ` [ovs-dev] " Gregory Rose
@ 2019-06-11 18:56 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2019-06-11 18:56 UTC (permalink / raw)
To: ap420073; +Cc: pshelar, netdev, dev
From: Taehee Yoo <ap420073@gmail.com>
Date: Mon, 10 Jun 2019 02:19:06 +0900
> ASSERT_OVSL() in ovs_vport_del() is unnecessary because
> ovs_vport_del() is only called by ovs_dp_detach_port() and
> ovs_dp_detach_port() calls ASSERT_OVSL() too.
>
> Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-11 18:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-09 17:19 [PATCH net-next] net: openvswitch: remove unnecessary ASSERT_OVSL in ovs_vport_del() Taehee Yoo
2019-06-10 21:13 ` [ovs-dev] " Gregory Rose
2019-06-11 18:56 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).