From: Ido Schimmel <idosch@idosch.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: Andrew Lunn <andrew@lunn.ch>,
davem@davemloft.net, netdev@vger.kernel.org, amitc@mellanox.com,
mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next 1/3] selftests: mlxsw: Add ethtool_lib.sh
Date: Tue, 11 Jun 2019 09:51:35 +0300 [thread overview]
Message-ID: <20190611065135.GB6167@splinter> (raw)
In-Reply-To: <bfd47cd0-2998-d2b9-7478-fb8cc6fee87c@gmail.com>
On Mon, Jun 10, 2019 at 08:29:54AM -0700, Florian Fainelli wrote:
> On 6/10/2019 6:56 AM, Ido Schimmel wrote:
> > On Mon, Jun 10, 2019 at 03:35:38PM +0200, Andrew Lunn wrote:
> >> On Mon, Jun 10, 2019 at 11:40:43AM +0300, Ido Schimmel wrote:
> >>> From: Amit Cohen <amitc@mellanox.com>
> >>> +declare -A speed_values
> >>> +
> >>> +speed_values=( [10baseT/Half]=0x001
> >>> + [10baseT/Full]=0x002
> >>> + [100baseT/Half]=0x004
> >>> + [100baseT/Full]=0x008
> >>> + [1000baseT/Half]=0x010
> >>> + [1000baseT/Full]=0x020
> >>
> >> Hi Ido, Amit
> >>
> >> 100BaseT1 and 1000BaseT1 were added recently.
> >
> > Hi Andrew,
> >
> > Didn't see them in the man page, so didn't include them. I now see your
> > patches are in the queue. Will add these speeds in v2.
>
> Could we extract the values from include/uapi/linux/ethtool.h, that way
> we would not have to have to update the selftest speed_values() array here?
Hi Florian,
Sounds reasonable. Will try this out.
next prev parent reply other threads:[~2019-06-11 6:51 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 8:40 [PATCH net-next 0/3] mlxsw: Add speed and auto-negotiation test Ido Schimmel
2019-06-10 8:40 ` [PATCH net-next 1/3] selftests: mlxsw: Add ethtool_lib.sh Ido Schimmel
2019-06-10 13:35 ` Andrew Lunn
2019-06-10 13:56 ` Ido Schimmel
2019-06-10 15:29 ` Florian Fainelli
2019-06-11 6:51 ` Ido Schimmel [this message]
2019-06-10 13:59 ` Andrew Lunn
2019-06-10 14:31 ` Ido Schimmel
2019-06-10 14:51 ` Andrew Lunn
2019-06-10 8:40 ` [PATCH net-next 2/3] selftests: mlxsw: lib.sh: Add wait for dev with timeout Ido Schimmel
2019-06-10 8:40 ` [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test Ido Schimmel
2019-06-10 13:48 ` Andrew Lunn
2019-06-10 13:58 ` Ido Schimmel
2019-06-10 14:06 ` Andrew Lunn
2019-06-11 6:35 ` Ido Schimmel
2019-06-11 12:22 ` Andrew Lunn
2019-06-11 13:06 ` Ido Schimmel
2019-06-11 13:30 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611065135.GB6167@splinter \
--to=idosch@idosch.org \
--cc=amitc@mellanox.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).