From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D25F4C43218 for ; Tue, 11 Jun 2019 06:51:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 98725208E3 for ; Tue, 11 Jun 2019 06:51:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="El1XBmf9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404129AbfFKGvk (ORCPT ); Tue, 11 Jun 2019 02:51:40 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41709 "EHLO out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725766AbfFKGvj (ORCPT ); Tue, 11 Jun 2019 02:51:39 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id EEE32223AB; Tue, 11 Jun 2019 02:51:38 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Tue, 11 Jun 2019 02:51:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=JNGKLS zxgUIdG5wJkQvEnXIbykcjKGkYB8W4spYw9Io=; b=El1XBmf9WgOhXUGstG1+6x DFMDdDqK7w+RDKc4d+BP06qJnNpQ04Z9ggCSTQxrAY1tK4BgdKGJm8EAGz69aS55 5tsNTlVRqcTlnN/1FX00lVIX3Y5xcIGcfFg0Gv9u8Lqwt8PoDr+kFbGWNzc0Po5x MSdGIaB+5SIn31QP2FhbChfl/FWjWnVGquDKQDi6gF+Yuy8cHK4rd+hKkEK7Hm3Q xhbj1cWnfOZPAWgeZWILr4brx+hhJ3X9qYnsXtaSg5oHTveTajijwLheWeZVY25j N4X+Y7FLAvIXEJnY7Zrb/HCy2oKdMLxkOEzFYGee+6CFPbrdjtnWh+xl8JjUooVw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudehfedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujggfsehttdertddtredvnecuhfhrohhmpefkugho ucfutghhihhmmhgvlhcuoehiughoshgthhesihguohhstghhrdhorhhgqeenucfkphepud elfedrgeejrdduieehrddvhedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgt hhesihguohhstghhrdhorhhgnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from localhost (unknown [193.47.165.251]) by mail.messagingengine.com (Postfix) with ESMTPA id 23D588005C; Tue, 11 Jun 2019 02:51:37 -0400 (EDT) Date: Tue, 11 Jun 2019 09:51:35 +0300 From: Ido Schimmel To: Florian Fainelli Cc: Andrew Lunn , davem@davemloft.net, netdev@vger.kernel.org, amitc@mellanox.com, mlxsw@mellanox.com, Ido Schimmel Subject: Re: [PATCH net-next 1/3] selftests: mlxsw: Add ethtool_lib.sh Message-ID: <20190611065135.GB6167@splinter> References: <20190610084045.6029-1-idosch@idosch.org> <20190610084045.6029-2-idosch@idosch.org> <20190610133538.GF8247@lunn.ch> <20190610135651.GA19495@splinter> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.3 (2019-02-01) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jun 10, 2019 at 08:29:54AM -0700, Florian Fainelli wrote: > On 6/10/2019 6:56 AM, Ido Schimmel wrote: > > On Mon, Jun 10, 2019 at 03:35:38PM +0200, Andrew Lunn wrote: > >> On Mon, Jun 10, 2019 at 11:40:43AM +0300, Ido Schimmel wrote: > >>> From: Amit Cohen > >>> +declare -A speed_values > >>> + > >>> +speed_values=( [10baseT/Half]=0x001 > >>> + [10baseT/Full]=0x002 > >>> + [100baseT/Half]=0x004 > >>> + [100baseT/Full]=0x008 > >>> + [1000baseT/Half]=0x010 > >>> + [1000baseT/Full]=0x020 > >> > >> Hi Ido, Amit > >> > >> 100BaseT1 and 1000BaseT1 were added recently. > > > > Hi Andrew, > > > > Didn't see them in the man page, so didn't include them. I now see your > > patches are in the queue. Will add these speeds in v2. > > Could we extract the values from include/uapi/linux/ethtool.h, that way > we would not have to have to update the selftest speed_values() array here? Hi Florian, Sounds reasonable. Will try this out.