From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C7C0C43218 for ; Tue, 11 Jun 2019 12:23:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D19F220673 for ; Tue, 11 Jun 2019 12:23:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="m0bjiX0a" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388562AbfFKMXD (ORCPT ); Tue, 11 Jun 2019 08:23:03 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:44916 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387444AbfFKMXD (ORCPT ); Tue, 11 Jun 2019 08:23:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Xsi4I9b8jQUj9O8gNQAZWzl5K4o1yUBDhSJ2bZqbfrk=; b=m0bjiX0a9D9h4U98ed9XszbfpZ KIr2CXTN/yclWM714f0ZBDpR8spTYoBi0UW+7wMjzcsqYO5z1T8e/TO6XDXynRFwc6iAqljNNCgRo G7GPnlaTW0TGhuvlJNIbGFDdBqf3jb1CNTqzhx+CBlRgJZP+0XsbWFn+clHsHztXBZ5A=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hafnj-0005YH-Dd; Tue, 11 Jun 2019 14:22:55 +0200 Date: Tue, 11 Jun 2019 14:22:55 +0200 From: Andrew Lunn To: Ido Schimmel Cc: davem@davemloft.net, netdev@vger.kernel.org, amitc@mellanox.com, mlxsw@mellanox.com, Ido Schimmel Subject: Re: [PATCH net-next 3/3] selftests: mlxsw: Add speed and auto-negotiation test Message-ID: <20190611122255.GB20904@lunn.ch> References: <20190610084045.6029-1-idosch@idosch.org> <20190610084045.6029-4-idosch@idosch.org> <20190610134820.GG8247@lunn.ch> <20190610135848.GB19495@splinter> <20190610140633.GI8247@lunn.ch> <20190611063526.GA6167@splinter> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190611063526.GA6167@splinter> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jun 11, 2019 at 09:35:26AM +0300, Ido Schimmel wrote: > On Mon, Jun 10, 2019 at 04:06:33PM +0200, Andrew Lunn wrote: > > On Mon, Jun 10, 2019 at 04:58:48PM +0300, Ido Schimmel wrote: > > > On Mon, Jun 10, 2019 at 03:48:20PM +0200, Andrew Lunn wrote: > > > > > + # Skip 56G because this speed isn't supported with autoneg off. > > > > > + if [[ $speed == 56000 ]]; then > > > > > + continue > > > > > + fi > > > > > > > > Interesting. How is 56000 represented in ethtool? Listed in both > > > > "Supported link modes" and "Advertised link modes"? > > > > > > Hi Andrew, > > > > > > Yes. We recently sent a patch to error out if autoneg is off: Commit > > > 275e928f1911 ("mlxsw: spectrum: Prevent force of 56G"). > > > > I never get access to high speed links like this. Do you have a > > reference to why 56G needs auto-neg? What makes it different to every > > other link mode? > > Hi Andrew, > > I verified with PHY engineers and this limitation is specific to our > hardware, so no external reference I can provide. Hi Ido Could you detect your own hardware and only enable this exception when needed? Thanks Andrew