From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DATE_IN_PAST_24_48, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 304B4C31E4A for ; Thu, 13 Jun 2019 15:15:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 104A920449 for ; Thu, 13 Jun 2019 15:15:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732817AbfFMPP1 (ORCPT ); Thu, 13 Jun 2019 11:15:27 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:41451 "EHLO relay6-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726933AbfFMNZa (ORCPT ); Thu, 13 Jun 2019 09:25:30 -0400 X-Originating-IP: 90.88.159.246 Received: from localhost (aaubervilliers-681-1-40-246.w90-88.abo.wanadoo.fr [90.88.159.246]) (Authenticated sender: maxime.ripard@bootlin.com) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id B224FC0002; Thu, 13 Jun 2019 13:25:15 +0000 (UTC) Date: Tue, 11 Jun 2019 16:58:56 +0200 From: Maxime Ripard To: Rob Herring Cc: Andrew Lunn , Mark Rutland , Frank Rowand , "David S . Miller" , Chen-Yu Tsai , Maxime Coquelin , Alexandre Torgue , netdev , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Maxime Chevallier , Antoine =?utf-8?Q?T=C3=A9nart?= , Florian Fainelli , Heiner Kallweit Subject: Re: [PATCH v2 05/11] dt-bindings: net: sun4i-emac: Convert the binding to a schemas Message-ID: <20190611145856.ua2ggkn6ccww6vpp@flea> References: <91618c7e9a5497462afa74c6d8a947f709f54331.1560158667.git-series.maxime.ripard@bootlin.com> <20190610143139.GG28724@lunn.ch> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="akgu3rpnhcjfd75m" Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org --akgu3rpnhcjfd75m Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Rob, On Mon, Jun 10, 2019 at 12:59:29PM -0600, Rob Herring wrote: > On Mon, Jun 10, 2019 at 8:31 AM Andrew Lunn wrote: > > > > > +required: > > > + - compatible > > > + - reg > > > + - interrupts > > > + - clocks > > > + - phy > > > + - allwinner,sram > > > > Quoting ethernet.txt: > > > > - phy: the same as "phy-handle" property, not recommended for new bindings. > > > > - phy-handle: phandle, specifies a reference to a node representing a PHY > > device; this property is described in the Devicetree Specification and so > > preferred; > > > > Can this be expressed in Yaml? Accept phy, but give a warning. Accept > > phy-handle without a warning? Enforce that one or the other is > > present? > > The common schema could have 'phy: false'. This works as long as we've > updated (or plan to) all the dts files to use phy-handle. The issue is > how far back do you need kernels to work with newer dtbs. I guess another question being raised by this is how hard do we want to be a deprecating things, and should the DT validation be a tool to enforce that validation. For example, you've used in you GPIO meta-schema false for anything ending with -gpio, since it's deprecated. This means that we can't convert any binding using a deprecated property without introducing a build error in the schemas, which in turn means that you'll have a lot of friction to support schemas, since you would have to convert your driver to support the new way of doing things, before being able to have a schema for your binding. And then, we need to agree on how to express the deprecation. I guess we could allow the deprecated keyword that will be there in the draft-8, instead of ad-hoc solutions? Maxime -- Maxime Ripard, Bootlin Embedded Linux and Kernel engineering https://bootlin.com --akgu3rpnhcjfd75m Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCXP/BsAAKCRDj7w1vZxhR xU7tAQDcrE7AmbrNpKlW8XjNBwjZBTaNMJbwICwP0nzygayxHQD+MjHzz6TZnhQF Qm1qbD7O25WDq9BPnYW8XMjLhY6IgQE= =f1jE -----END PGP SIGNATURE----- --akgu3rpnhcjfd75m--