Fw: [Bug 203867] New: invalid parameter to NL_SET_ERR_MSG_ATTR() in vxlan.c and geneve.c

Fw: [Bug 203867] New: invalid parameter to NL_SET_ERR_MSG_ATTR() in vxlan.c and geneve.c

[Stephen Hemminger]

Begin forwarded message:

Date: Wed, 12 Jun 2019 07:49:06 +0000
From: bugzilla-daemon@bugzilla.kernel.org
To: stephen@networkplumber.org
Subject: [Bug 203867] New: invalid parameter to NL_SET_ERR_MSG_ATTR() in vxlan.c and geneve.c


https://bugzilla.kernel.org/show_bug.cgi?id=203867

            Bug ID: 203867
           Summary: invalid parameter to NL_SET_ERR_MSG_ATTR() in vxlan.c
                    and geneve.c
           Product: Networking
           Version: 2.5
    Kernel Version: v5.2.0-rc4
          Hardware: All
                OS: Linux
              Tree: Mainline
            Status: NEW
          Severity: normal
          Priority: P1
         Component: Other
          Assignee: stephen@networkplumber.org
          Reporter: krkx2@sovintel.ru
        Regression: No

Created attachment 283213
  --> https://bugzilla.kernel.org/attachment.cgi?id=283213&action=edit  
patch for vxlan.c and geneve.c

Looks like invalid 'attr' parameter is passed to NL_SET_ERR_MSG_ATTR() in
drivers/net/vxlan.c and drivers/net/geneve.c for number of attributes.

For example `tb[IFLA_VXLAN_PORT_RANGE]` instead of
`data[IFLA_VXLAN_PORT_RANGE]` in piece of code below.

        if (data[IFLA_VXLAN_PORT_RANGE]) {
                const struct ifla_vxlan_port_range *p
                        = nla_data(data[IFLA_VXLAN_PORT_RANGE]);

                if (ntohs(p->high) < ntohs(p->low)) {
                        NL_SET_ERR_MSG_ATTR(extack, tb[IFLA_VXLAN_PORT_RANGE],
                                            "Invalid source port range");
                        return -EINVAL;
                }
        }

In case this is really a bug, patch is provided in attach.

-- 
You are receiving this mail because:
You are the assignee for the bug.