From: Stephen Hemminger <stephen@networkplumber.org>
To: Matteo Croce <mcroce@redhat.com>
Cc: netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>
Subject: Re: [PATCH iproute2] testsuite: don't clobber /tmp
Date: Wed, 12 Jun 2019 08:53:07 -0700 [thread overview]
Message-ID: <20190612085307.35e42bf4@hermes.lan> (raw)
In-Reply-To: <20190611180326.30597-1-mcroce@redhat.com>
On Tue, 11 Jun 2019 20:03:26 +0200
Matteo Croce <mcroce@redhat.com> wrote:
> Even if not running the testsuite, every build will leave
> a stale tc_testkenv.* file in the system temp directory.
> Conditionally create the temp file only if we're running the testsuite.
>
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> ---
> testsuite/Makefile | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/testsuite/Makefile b/testsuite/Makefile
> index 7f247bbc..5353244b 100644
> --- a/testsuite/Makefile
> +++ b/testsuite/Makefile
> @@ -14,7 +14,9 @@ TESTS_DIR := $(dir $(TESTS))
>
> IPVERS := $(filter-out iproute2/Makefile,$(wildcard iproute2/*))
>
> -KENVFN := $(shell mktemp /tmp/tc_testkenv.XXXXXX)
> +ifeq ($(MAKECMDGOALS),alltests)
> + KENVFN := $(shell mktemp /tmp/tc_testkenv.XXXXXX)
> +endif
> ifneq (,$(wildcard /proc/config.gz))
> KCPATH := /proc/config.gz
> else
> @@ -94,3 +96,4 @@ endif
> rm "$$TMP_ERR" "$$TMP_OUT"; \
> sudo dmesg > $(RESULTS_DIR)/$@.$$o.dmesg; \
> done
> + @$(RM) $(KENVFN)
My concern is that there are several targets in this one Makefile.
Why not use -u which gives name but does not create the file?
next prev parent reply other threads:[~2019-06-12 15:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 18:03 [PATCH iproute2] testsuite: don't clobber /tmp Matteo Croce
2019-06-12 15:53 ` Stephen Hemminger [this message]
2019-06-12 16:04 ` Matteo Croce
2019-06-12 17:32 ` Matteo Croce
2019-06-12 18:19 ` Stephen Hemminger
2019-06-13 17:15 ` Matteo Croce
2019-06-25 14:39 ` Matteo Croce
2019-10-12 13:32 ` Matteo Croce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612085307.35e42bf4@hermes.lan \
--to=stephen@networkplumber.org \
--cc=dsahern@kernel.org \
--cc=mcroce@redhat.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).