From: Andrew Lunn <andrew@lunn.ch>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Anders Roxell <anders.roxell@linaro.org>,
"David S. Miller" <davem@davemloft.net>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
netdev <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] drivers: net: dsa: fix warning same module names
Date: Wed, 12 Jun 2019 15:16:47 +0200 [thread overview]
Message-ID: <20190612131647.GD23615@lunn.ch> (raw)
In-Reply-To: <CACRpkdbhRAdybqKdMgyM9Jy=eSJaRHjTpuOZO=KBgeaCbcP88Q@mail.gmail.com>
On Wed, Jun 12, 2019 at 02:36:44PM +0200, Linus Walleij wrote:
> On Wed, Jun 12, 2019 at 10:11 AM Anders Roxell <anders.roxell@linaro.org> wrote:
>
> > When building with CONFIG_NET_DSA_REALTEK_SMI and CONFIG_REALTEK_PHY
> > enabled as loadable modules, we see the following warning:
> >
> > warning: same module names found:
> > drivers/net/phy/realtek.ko
> > drivers/net/dsa/realtek.ko
> >
> > Rework so the driver name is rtl8366 instead of realtek.
> >
> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org>
>
> Sorry for giving bad advice here on IRC... my wrong.
>
> > -obj-$(CONFIG_NET_DSA_REALTEK_SMI) += realtek.o
> > -realtek-objs := realtek-smi.o rtl8366.o rtl8366rb.o
> > +obj-$(CONFIG_NET_DSA_REALTEK_SMI) += rtl8366.o
> > +rtl8366-objs := realtek-smi.o rtl8366-common.o rtl8366rb.o
>
> What is common for this family is not the name rtl8366
> (there is for example rtl8369 in this family, we just haven't
> added it yet) but the common technical item is SMI.
Hi Linus
I was not sure about this. I thought SMI was the bus used to
communicate with the switch. It just seemed odd to call a switch
family after the bus.
Anyway, if you are happy with the name realtek-smi:
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2019-06-12 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 8:11 [PATCH v2] drivers: net: dsa: fix warning same module names Anders Roxell
2019-06-12 12:36 ` Linus Walleij
2019-06-12 13:16 ` Andrew Lunn [this message]
2019-06-12 18:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612131647.GD23615@lunn.ch \
--to=andrew@lunn.ch \
--cc=anders.roxell@linaro.org \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).