From: Guillaume Nault <gnault@redhat.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "David S. Miller" <davem@davemloft.net>,
Guillaume Nault <g.nault@alphalink.fr>,
netdev@vger.kernel.org
Subject: Re: [PATCH] l2tp: no need to check return value of debugfs_create functions
Date: Fri, 14 Jun 2019 13:55:07 +0200 [thread overview]
Message-ID: <20190614115506.GA28890@linux.home> (raw)
In-Reply-To: <20190614070438.GA25351@kroah.com>
On Fri, Jun 14, 2019 at 09:04:38AM +0200, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> Also, there is no need to store the individual debugfs file name, just
> remove the whole directory all at once, saving a local variable.
>
Acked-by: Guillaume Nault <gnault@redhat.com>
next prev parent reply other threads:[~2019-06-14 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 7:04 [PATCH] l2tp: no need to check return value of debugfs_create functions Greg Kroah-Hartman
2019-06-14 11:55 ` Guillaume Nault [this message]
2019-06-14 15:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614115506.GA28890@linux.home \
--to=gnault@redhat.com \
--cc=davem@davemloft.net \
--cc=g.nault@alphalink.fr \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).