From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_NEOMUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E6D7C31E50 for ; Sat, 15 Jun 2019 00:03:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0C88A21773 for ; Sat, 15 Jun 2019 00:03:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726494AbfFOACt (ORCPT ); Fri, 14 Jun 2019 20:02:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51714 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726126AbfFOACt (ORCPT ); Fri, 14 Jun 2019 20:02:49 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3CCA83082E4F; Sat, 15 Jun 2019 00:02:49 +0000 (UTC) Received: from treble (ovpn-112-39.rdu2.redhat.com [10.10.112.39]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1BA0B1001B23; Sat, 15 Jun 2019 00:02:44 +0000 (UTC) Date: Fri, 14 Jun 2019 19:02:42 -0500 From: Josh Poimboeuf To: Alexei Starovoitov Cc: X86 ML , Alexei Starovoitov , LKML , Daniel Borkmann , Network Development , bpf , Peter Zijlstra , Song Liu , Kairui Song , Steven Rostedt , David Laight , Thomas Gleixner , Borislav Petkov , Ingo Molnar Subject: Re: [PATCH v2 2/5] objtool: Fix ORC unwinding in non-JIT BPF generated code Message-ID: <20190615000242.e5tcogffvyuuhnrs@treble> References: <20190614205841.s4utbpurntpr6aiq@ast-mbp.dhcp.thefacebook.com> <20190614210745.kwiqm5pkgabruzuj@treble> <20190614211929.drnnawbi7guqj2ck@treble> <20190614231717.xukbfpc2cy47s4xh@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Sat, 15 Jun 2019 00:02:49 +0000 (UTC) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Jun 14, 2019 at 04:30:15PM -0700, Alexei Starovoitov wrote: > On Fri, Jun 14, 2019 at 4:17 PM Josh Poimboeuf wrote: > > > > On Fri, Jun 14, 2019 at 02:22:59PM -0700, Alexei Starovoitov wrote: > > > On Fri, Jun 14, 2019 at 2:19 PM Josh Poimboeuf wrote: > > > > > > > > > > > > > > > > +#define JUMP_TABLE_SYM_PREFIX "jump_table." > > > > > > > > > > > > > > since external tool will be looking at it should it be named > > > > > > > "bpf_jump_table." to avoid potential name conflicts? > > > > > > > Or even more unique name? > > > > > > > Like "bpf_interpreter_jump_table." ? > > > > > > > > > > > > No, the point is that it's a generic feature which can also be used any > > > > > > non-BPF code which might also have a jump table. > > > > > > > > > > and you're proposing to name all such jump tables in the kernel > > > > > as static foo jump_table[] ? > > > > > > > > That's the idea. > > > > > > Then it needs much wider discussion. > > > > Why would it need wider discussion? It only has one user. If you > > honestly believe that it will be controversial to require future users > > to call a static jump table "jump_table" then we can have that > > discussion when it comes up. > > It's clearly controversial. > I nacked it already on pointless name change > from "jumptable" to "jump_table" and now you're saying > that no one will complain about "jump_table" name > for all jump tables in the kernel that will ever appear? Let me get this straight. You're saying that "jumptable" and "bpf_interpreter_jump_table" are both acceptable. But NACK to "jump_table". Ok... -- Josh