From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: David Miller <davem@davemloft.net>
Cc: ioana.ciornei@nxp.com, andrew@lunn.ch, f.fainelli@gmail.com,
hkallweit1@gmail.com, netdev@vger.kernel.org
Subject: Re: [PATCH] net: phylink: set the autoneg state in phylink_phy_change
Date: Sat, 15 Jun 2019 23:13:28 +0100 [thread overview]
Message-ID: <20190615221328.4diebpopfzyfi4og@shell.armlinux.org.uk> (raw)
In-Reply-To: <20190615.133021.572699563162351841.davem@davemloft.net>
On Sat, Jun 15, 2019 at 01:30:21PM -0700, David Miller wrote:
> From: Ioana Ciornei <ioana.ciornei@nxp.com>
> Date: Thu, 13 Jun 2019 09:37:51 +0300
>
> > The phy_state field of phylink should carry only valid information
> > especially when this can be passed to the .mac_config callback.
> > Update the an_enabled field with the autoneg state in the
> > phylink_phy_change function.
> >
> > Fixes: 9525ae83959b ("phylink: add phylink infrastructure")
> > Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
>
> Applied and queued up for -stable, thanks.
This is not a fix; it is an attempt to make phylink work differently
from how it's been designed for the dpaa2 driver. I've already stated
that this field is completely meaningless, so I'm surprised you
applied it.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-06-15 22:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 6:37 [PATCH] net: phylink: set the autoneg state in phylink_phy_change Ioana Ciornei
2019-06-13 7:45 ` Ioana Ciornei
2019-06-13 8:14 ` Russell King - ARM Linux admin
2019-06-13 8:55 ` Ioana Ciornei
2019-06-13 9:34 ` Russell King - ARM Linux admin
2019-06-13 14:32 ` Ioana Ciornei
2019-06-13 14:41 ` Russell King - ARM Linux admin
2019-06-13 14:56 ` Ioana Ciornei
2019-06-15 20:30 ` David Miller
2019-06-15 22:13 ` Russell King - ARM Linux admin [this message]
2019-06-16 1:08 ` David Miller
2019-06-16 9:42 ` Russell King - ARM Linux admin
2019-06-20 14:40 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190615221328.4diebpopfzyfi4og@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).