From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=j/VV=UQ=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED
	autolearn=ham autolearn_force=no version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id EE812C31E5B
	for <netdev@archiver.kernel.org>; Mon, 17 Jun 2019 21:06:41 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id C1DE420861
	for <netdev@archiver.kernel.org>; Mon, 17 Jun 2019 21:06:41 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1727189AbfFQVGk (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 17 Jun 2019 17:06:40 -0400
Received: from shards.monkeyblade.net ([23.128.96.9]:38346 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725497AbfFQVGk (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 17 Jun 2019 17:06:40 -0400
Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 2EA01151397AE;
        Mon, 17 Jun 2019 14:06:40 -0700 (PDT)
Date:   Mon, 17 Jun 2019 14:06:39 -0700 (PDT)
Message-Id: <20190617.140639.2221973922220817249.davem@davemloft.net>
To:     jiri@resnulli.us
Cc:     netdev@vger.kernel.org, mlxsw@mellanox.com, eli@mellanox.com,
        jhs@mojatatu.com, xiyou.wangcong@gmail.com
Subject: Re: [patch net-next] net: sched: cls_matchall: allow to delete
 filter
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20190617160232.7599-1-jiri@resnulli.us>
References: <20190617160232.7599-1-jiri@resnulli.us>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 17 Jun 2019 14:06:40 -0700 (PDT)
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

From: Jiri Pirko <jiri@resnulli.us>
Date: Mon, 17 Jun 2019 18:02:32 +0200

> From: Jiri Pirko <jiri@mellanox.com>
> 
> Currently user is unable to delete the filter. See following example:
> $ tc filter add dev ens16np1 ingress pref 1 handle 1 matchall action drop
> $ tc filter show dev ens16np1 ingress
> filter protocol all pref 1 matchall chain 0
> filter protocol all pref 1 matchall chain 0 handle 0x1
>   in_hw
>         action order 1: gact action drop
>          random type none pass val 0
>          index 1 ref 1 bind 1
> 
> $ tc filter del dev ens16np1 ingress pref 1 handle 1 matchall action drop
> RTNETLINK answers: Operation not supported
> 
> Implement tcf_proto_ops->delete() op and allow user to delete the filter.
> 
> Reported-by: Eli Cohen <eli@mellanox.com>
> Signed-off-by: Jiri Pirko <jiri@mellanox.com>

Applied, thanks.