From: David Miller <davem@davemloft.net>
To: lucien.xin@gmail.com
Cc: netdev@vger.kernel.org, jon.maloy@ericsson.com,
ying.xue@windriver.com, tipc-discussion@lists.sourceforge.net,
marcelo.leitner@gmail.com, nhorman@tuxdriver.com,
suyj.fnst@cn.fujitsu.com, dsahern@gmail.com,
syzkaller-bugs@googlegroups.com, dvyukov@google.com,
pshelar@nicira.com
Subject: Re: [PATCH net 0/3] net: fix quite a few dst_cache crashes reported by syzbot
Date: Tue, 18 Jun 2019 20:49:38 -0400 (EDT) [thread overview]
Message-ID: <20190618.204938.1560433170435338986.davem@davemloft.net> (raw)
In-Reply-To: <cover.1560778340.git.lucien.xin@gmail.com>
From: Xin Long <lucien.xin@gmail.com>
Date: Mon, 17 Jun 2019 21:34:12 +0800
> There are two kinds of crashes reported many times by syzbot with no
> reproducer. Call Traces are like:
...
> They were caused by the fib_nh_common percpu member 'nhc_pcpu_rth_output'
> overwritten by another percpu variable 'dev->tstats' access overflow in
> tipc udp media xmit path when counting packets on a non tunnel device.
>
> The fix is to make udp tunnel work with no tunnel device by allowing not
> to count packets on the tstats when the tunnel dev is NULL in Patches 1/3
> and 2/3, then pass a NULL tunnel dev in tipc_udp_tunnel() in Patch 3/3.
Series applied and queued up for -stable.
Thanks for putting all of those syzbot reported by tags in there.
prev parent reply other threads:[~2019-06-19 0:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 13:34 [PATCH net 0/3] net: fix quite a few dst_cache crashes reported by syzbot Xin Long
2019-06-17 13:34 ` [PATCH net 1/3] ip_tunnel: allow not to count pkts on tstats by setting skb's dev to NULL Xin Long
2019-06-17 13:34 ` [PATCH net 2/3] ip6_tunnel: allow not to count pkts on tstats by passing dev as NULL Xin Long
2019-06-17 13:34 ` [PATCH net 3/3] tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb Xin Long
2019-06-19 0:49 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618.204938.1560433170435338986.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=dvyukov@google.com \
--cc=jon.maloy@ericsson.com \
--cc=lucien.xin@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pshelar@nicira.com \
--cc=suyj.fnst@cn.fujitsu.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).