From: David Miller <davem@davemloft.net>
To: nhuck@google.com
Cc: maxime.chevallier@bootlin.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, clang-built-linux@googlegroups.com
Subject: Re: [PATCH] net: mvpp2: cls: Add pmap to fs dump
Date: Tue, 18 Jun 2019 22:33:43 -0400 (EDT) [thread overview]
Message-ID: <20190618.223343.1129504320231308025.davem@davemloft.net> (raw)
In-Reply-To: <20190618160910.62922-1-nhuck@google.com>
From: Nathan Huckleberry <nhuck@google.com>
Date: Tue, 18 Jun 2019 09:09:10 -0700
> + ddebugfs_create_file("pmap", 0444, prs_entry_dir, entry,
drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c: In function ‘mvpp2_dbgfs_prs_entry_init’:
drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c:569:2: error: implicit declaration of function ‘ddebugfs_create_file’; did you mean ‘debugfs_create_file’? [-Werror=implicit-function-declaration]
This doesn't compile, did you build test this?
next prev parent reply other threads:[~2019-06-19 2:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 17:53 Cleanup of -Wunused-const-variable in drivers/net/ethernet/marvell/mvpp2/mvpp2_debugfs.c Nathan Huckleberry
2019-06-18 6:39 ` Maxime Chevallier
2019-06-18 16:09 ` [PATCH] net: mvpp2: cls: Add pmap to fs dump Nathan Huckleberry
2019-06-18 19:00 ` Nick Desaulniers
2019-06-19 2:33 ` David Miller [this message]
2019-06-19 6:49 ` Maxime Chevallier
2019-06-19 18:17 ` [PATCH v2] net: mvpp2: debugfs: " Nathan Huckleberry
2019-06-19 20:46 ` Nick Desaulniers
2019-06-19 21:20 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618.223343.1129504320231308025.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=nhuck@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).