From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>,
<davem@davemloft.net>, <netdev@vger.kernel.org>,
Anirudh Gupta <anirudh.gupta@sophos.com>
Subject: Re: [PATCH ipsec] xfrm: fix sa selector validation
Date: Tue, 18 Jun 2019 09:27:39 +0200 [thread overview]
Message-ID: <20190618072739.GY17989@gauss3.secunet.de> (raw)
In-Reply-To: <20190614161148.vti6mhvnxfwweznc@gondor.apana.org.au>
On Sat, Jun 15, 2019 at 12:11:48AM +0800, Herbert Xu wrote:
> On Fri, Jun 14, 2019 at 11:13:55AM +0200, Nicolas Dichtel wrote:
> > After commit b38ff4075a80, the following command does not work anymore:
> > $ ip xfrm state add src 10.125.0.2 dst 10.125.0.1 proto esp spi 34 reqid 1 \
> > mode tunnel enc 'cbc(aes)' 0xb0abdba8b782ad9d364ec81e3a7d82a1 auth-trunc \
> > 'hmac(sha1)' 0xe26609ebd00acb6a4d51fca13e49ea78a72c73e6 96 flag align4
> >
> > In fact, the selector is not mandatory, allow the user to provide an empty
> > selector.
> >
> > Fixes: b38ff4075a80 ("xfrm: Fix xfrm sel prefix length validation")
> > CC: Anirudh Gupta <anirudh.gupta@sophos.com>
> > Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Patch applied, thanks everyone!
prev parent reply other threads:[~2019-06-18 7:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 9:13 [PATCH ipsec] xfrm: fix sa selector validation Nicolas Dichtel
2019-06-14 16:11 ` Herbert Xu
2019-06-18 7:27 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618072739.GY17989@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=anirudh.gupta@sophos.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox