From: Greg KH <gregkh@linuxfoundation.org>
To: David Miller <davem@davemloft.net>
Cc: willemdebruijn.kernel@gmail.com, naresh.kamboju@linaro.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, fklassen@appneta.com
Subject: Re: 4.19: udpgso_bench_tx: setsockopt zerocopy: Unknown error 524
Date: Tue, 18 Jun 2019 19:15:16 +0200 [thread overview]
Message-ID: <20190618171516.GA17547@kroah.com> (raw)
In-Reply-To: <20190618.094759.539007481404905339.davem@davemloft.net>
On Tue, Jun 18, 2019 at 09:47:59AM -0700, David Miller wrote:
> From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
> Date: Tue, 18 Jun 2019 12:37:33 -0400
>
> > Specific to the above test, I can add a check command testing
> > setsockopt SO_ZEROCOPY return value. AFAIK kselftest has no explicit
> > way to denote "skipped", so this would just return "pass". Sounds a
> > bit fragile, passing success when a feature is absent.
>
> Especially since the feature might be absent because the 'config'
> template forgot to include a necessary Kconfig option.
That is what the "skip" response is for, don't return "pass" if the
feature just isn't present. That lets people run tests on systems
without the config option enabled as you say, or on systems without the
needed userspace tools present.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-18 17:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 11:27 4.19: udpgso_bench_tx: setsockopt zerocopy: Unknown error 524 Naresh Kamboju
2019-06-18 12:31 ` Willem de Bruijn
2019-06-18 16:10 ` Greg KH
2019-06-18 16:37 ` Willem de Bruijn
2019-06-18 16:47 ` David Miller
2019-06-18 17:15 ` Greg KH [this message]
2019-06-18 17:27 ` Willem de Bruijn
2019-06-18 17:39 ` Greg KH
2019-06-18 18:58 ` Willem de Bruijn
2019-06-18 20:04 ` Willem de Bruijn
2019-06-18 22:44 ` David Miller
2019-06-19 0:38 ` Willem de Bruijn
2019-06-18 17:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618171516.GA17547@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=davem@davemloft.net \
--cc=fklassen@appneta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=naresh.kamboju@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).