From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95521C31E5D for ; Tue, 18 Jun 2019 17:57:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7643B205F4 for ; Tue, 18 Jun 2019 17:57:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730091AbfFRR51 (ORCPT ); Tue, 18 Jun 2019 13:57:27 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:48487 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729753AbfFRR50 (ORCPT ); Tue, 18 Jun 2019 13:57:26 -0400 Received: from [5.158.153.53] (helo=nereus.lab.linutronix.de.) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1hdIMF-0006l3-UU; Tue, 18 Jun 2019 19:57:24 +0200 From: Benedikt Spranger To: netdev@vger.kernel.org Cc: Sebastian Andrzej Siewior , Benedikt Spranger Subject: [RFC PATCH 2/2] net: dsa: b53: enbale broadcom tags on bcm531x5 Date: Tue, 18 Jun 2019 19:57:12 +0200 Message-Id: <20190618175712.71148-3-b.spranger@linutronix.de> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20190618175712.71148-1-b.spranger@linutronix.de> References: <20190618175712.71148-1-b.spranger@linutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Sebastian Andrzej Siewior The broadcom tags are required to distinguish the traffic from external ports and not use a bridge like setup (which is currently broken because managed mode is now enabled). The tagged mode works for broadcast and unicast traffic. The multicast missis are not handled. Reviewed-by: Kurt Kanzenbach Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Benedikt Spranger --- drivers/net/dsa/b53/b53_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dsa/b53/b53_common.c b/drivers/net/dsa/b53/b53_common.c index 06b9a7a81ae0..10f1ece64104 100644 --- a/drivers/net/dsa/b53/b53_common.c +++ b/drivers/net/dsa/b53/b53_common.c @@ -1793,7 +1793,7 @@ enum dsa_tag_protocol b53_get_tag_protocol(struct dsa_switch *ds, int port) * mode to be turned on which means we need to specifically manage ARL * misses on multicast addresses (TBD). */ - if (is5325(dev) || is5365(dev) || is539x(dev) || is531x5(dev) || + if (is5325(dev) || is5365(dev) || is539x(dev) || !b53_can_enable_brcm_tags(ds, port)) return DSA_TAG_PROTO_NONE; -- 2.19.0