From: Ido Schimmel <idosch@idosch.org>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dsahern@gmail.com,
mlxsw@mellanox.com, Ido Schimmel <idosch@mellanox.com>
Subject: Re: [PATCH net-next v2] ipv6: Error when route does not have any valid nexthops
Date: Thu, 20 Jun 2019 13:12:50 +0300 [thread overview]
Message-ID: <20190620101250.GA18869@splinter> (raw)
In-Reply-To: <20190620092202.GC2504@nanopsycho>
On Thu, Jun 20, 2019 at 11:22:03AM +0200, Jiri Pirko wrote:
> Thu, Jun 20, 2019 at 11:10:21AM CEST, idosch@idosch.org wrote:
> >+ if (list_empty(&rt6_nh_list)) {
> >+ NL_SET_ERR_MSG(extack,
> >+ "Invalid nexthop configuration - no valid nexthops");
>
> No need for a line wrap.
I wanted to be consistent with the rest of the extack usage in this
function.
next prev parent reply other threads:[~2019-06-20 10:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 9:10 [PATCH net-next v2] ipv6: Error when route does not have any valid nexthops Ido Schimmel
2019-06-20 9:22 ` Jiri Pirko
2019-06-20 10:12 ` Ido Schimmel [this message]
2019-06-20 12:57 ` David Ahern
2019-06-22 23:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190620101250.GA18869@splinter \
--to=idosch@idosch.org \
--cc=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=idosch@mellanox.com \
--cc=jiri@resnulli.us \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).