From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7308C48BE1 for ; Thu, 20 Jun 2019 18:37:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B6751206BF for ; Thu, 20 Jun 2019 18:37:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=networkplumber-org.20150623.gappssmtp.com header.i=@networkplumber-org.20150623.gappssmtp.com header.b="OrHZBkER" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726452AbfFTShP (ORCPT ); Thu, 20 Jun 2019 14:37:15 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:37278 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726355AbfFTShO (ORCPT ); Thu, 20 Jun 2019 14:37:14 -0400 Received: by mail-pf1-f195.google.com with SMTP id 19so2148516pfa.4 for ; Thu, 20 Jun 2019 11:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5s/l0ITYvPky32c4CeJ1RE7LMqmdddmdnmEyaty1EJM=; b=OrHZBkERHshvedquCJ9byOzjBT0TgnCiZhTLxTEfgjlTEDWkSZ7xm23SjABY2IV7Z7 LjPocB8AGYGUUdHub0lz5lCaFc3zI4O9Pjb91wTwdEDIWnm4jqCZrdMNYbE6VUcOg21X xR+ch30YLe6NWjWRVf3BuBgQB9GQgDT+BoCz9VmF4MlXGzEhS+JCzFvBvaRbh67UrflN rtSy8aWlvd36lTbrlM/2epUswK1yO6E2GkG1zrkLYoDQEabNqXm3J3bCOl/hRxnLDsbQ vvN0Vg/f8B4wxfWplrEqSz4wd9o0VEYsCaSvbEV1c8y9DN1LgA8ABi2PGT/cQsHTR9Dw njcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5s/l0ITYvPky32c4CeJ1RE7LMqmdddmdnmEyaty1EJM=; b=T4dfQI5CUe1Ag0QtQ3i1K/nfLY/tasZrLf4Bb8s9vIWE+/6sss7ZbzUKewoVzACaNe 1HT+7z7Af75w5tvkiAwPpBz7Wlr7rxc7p/OYvcNPV7D9Su4BvrHV4WVLIWE7wjF/Pcgi ZHm7Eq7+x98j6yrDOYmhFvyTzORe3djt70YgRzAyFjWGEfiXWodxUYRTTZVZ10FsQwWq UaNC3MPC3JpnMJKY0yOhCXjYAs5VgZsnqrJ7r2PbH2kdu6j/42N4mpHMSBzGePEYRqyS a/tqFobdFMvdtFuxujansN+8B4JOdgW1gs5FzZPsd2TNCXIdJwpFp518FxF2MVWN2Dvj 6vdA== X-Gm-Message-State: APjAAAV2l7o8SQPhRATCL0YNO1hAJtgh6iqf7Zj91NYDQT53scArJHD4 /QYd+iBgl/dOC4yUACtZUKPLiw== X-Google-Smtp-Source: APXvYqy9uXyk4M5pYOIQFJAB76riuo9dsfgvNobIZLhtZVZfQ8ZXqn6fA3MIbw3Om8NFAwMk9dnxlA== X-Received: by 2002:a63:2249:: with SMTP id t9mr14261464pgm.149.1561055833946; Thu, 20 Jun 2019 11:37:13 -0700 (PDT) Received: from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127]) by smtp.gmail.com with ESMTPSA id y22sm386613pgj.38.2019.06.20.11.37.13 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 20 Jun 2019 11:37:13 -0700 (PDT) Date: Thu, 20 Jun 2019 11:37:12 -0700 From: Stephen Hemminger To: Puranjay Mohan Cc: Shuah Khan , Bjorn Helgaas , netdev , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v2 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Message-ID: <20190620113712.4630f60f@hermes.lan> In-Reply-To: <20190620180754.15413-1-puranjay12@gmail.com> References: <20190620180754.15413-1-puranjay12@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 20 Jun 2019 23:37:51 +0530 Puranjay Mohan wrote: > This patch series removes the private duplicates of PCI definitions in > favour of generic definitions defined in pci_regs.h. > > This driver only uses one of the generic PCI definitons, i.e. > PCI_REVISION_ID, which is included from pci_regs.h and its private > version is removed from skfbi.h with all other private defines. > > The skfbi.h defines PCI_REV_ID which is renamed to PCI_REVISION_ID in > drvfbi.c to make it compatible with the generic define in pci_regs.h. > > Puranjay Mohan (3): > net: fddi: skfp: Rename PCI_REV_ID to PCI_REVISION_ID > net: fddi: skfp: Include generic PCI definitions > net: fddi: skfp: Remove unused private PCI definitions > > drivers/net/fddi/skfp/drvfbi.c | 4 +- > drivers/net/fddi/skfp/h/skfbi.h | 207 +------------------------------- > 2 files changed, 3 insertions(+), 208 deletions(-) > Does anyone still have the hardware to test this? Maybe FDDI should be put out to pasture.