From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D2D1C43613 for ; Fri, 21 Jun 2019 09:27:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 004FB21530 for ; Fri, 21 Jun 2019 09:27:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726282AbfFUJ1x (ORCPT ); Fri, 21 Jun 2019 05:27:53 -0400 Received: from mga12.intel.com ([192.55.52.136]:44274 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726210AbfFUJ1w (ORCPT ); Fri, 21 Jun 2019 05:27:52 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jun 2019 02:27:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,399,1557212400"; d="scan'208";a="311941655" Received: from lkp-server01.sh.intel.com (HELO lkp-server01) ([10.239.97.150]) by orsmga004.jf.intel.com with ESMTP; 21 Jun 2019 02:27:50 -0700 Received: from kbuild by lkp-server01 with local (Exim 4.89) (envelope-from ) id 1heFpm-0006Bl-9h; Fri, 21 Jun 2019 17:27:50 +0800 Date: Fri, 21 Jun 2019 17:27:23 +0800 From: kbuild test robot To: Shannon Nelson Cc: kbuild-all@01.org, snelson@pensando.io, netdev@vger.kernel.org Subject: [PATCH] ionic: fix simple_open.cocci warnings Message-ID: <20190621092723.GA96768@lkp-kbuild10> References: <20190620202424.23215-3-snelson@pensando.io> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190620202424.23215-3-snelson@pensando.io> X-Patchwork-Hint: ignore User-Agent: Mutt/1.5.23 (2014-03-12) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: kbuild test robot drivers/net/ethernet/pensando/ionic/ionic_debugfs.c:12:11-20: WARNING opportunity for simple_open, see also structure on line 56 Remove an open coded simple_open() function and replace file operations references to the function with simple_open() instead. Generated by: scripts/coccinelle/api/simple_open.cocci Fixes: fb4f52d18a75 ("ionic: Add hardware init and device commands") CC: Shannon Nelson Signed-off-by: kbuild test robot --- url: https://github.com/0day-ci/linux/commits/Shannon-Nelson/ionic-Add-basic-framework-for-IONIC-Network-device-driver/20190621-110046 ionic_debugfs.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) --- a/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c +++ b/drivers/net/ethernet/pensando/ionic/ionic_debugfs.c @@ -9,12 +9,6 @@ #ifdef CONFIG_DEBUG_FS -static int blob_open(struct inode *inode, struct file *filp) -{ - filp->private_data = inode->i_private; - return 0; -} - static ssize_t blob_read(struct file *filp, char __user *buffer, size_t count, loff_t *ppos) { @@ -53,7 +47,7 @@ static ssize_t blob_write(struct file *f static const struct file_operations blob_fops = { .owner = THIS_MODULE, - .open = blob_open, + .open = simple_open, .read = blob_read, .write = blob_write, };