From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0AA8C43613 for ; Fri, 21 Jun 2019 15:19:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4175206B7 for ; Fri, 21 Jun 2019 15:19:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="gJQ2uBPn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726063AbfFUPTa (ORCPT ); Fri, 21 Jun 2019 11:19:30 -0400 Received: from mail-wr1-f68.google.com ([209.85.221.68]:35668 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726017AbfFUPTa (ORCPT ); Fri, 21 Jun 2019 11:19:30 -0400 Received: by mail-wr1-f68.google.com with SMTP id m3so7005853wrv.2 for ; Fri, 21 Jun 2019 08:19:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=3VbzSB5yjaWLuskB1X5KhErGhgQBo8TZe9ClLCDNvO8=; b=gJQ2uBPnHJjzvdAqxeUsYwzMBXQNFRmJGysF4PhRRXj1N7M08zil1kDmCYId7ChgTy YCQwRA66ur8Jn6tz5yK5+fTy8xjO3VuCx9+MtPjyyDA91rw0LZu/5QQ8pHOXbOKgb68p tvFJzqihOuqvtKkxYIvnQJeTIrRp5iNMG/Z0XlixJN60go1kT64511pMV2nLRvUDWthZ cKd5T7CO/bD6lhn4yFP5rZDqNIZDHrRYahQ/oqWoAddQcv3C9WkqfFy3hD7VxMSWyXnq CY46AVVJZhYLRIU1fSHc7VZZRKhrfdk3zpAGboWzTYVMwSZC63cWAUZZnC64Cgtxh6bz 6ncQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=3VbzSB5yjaWLuskB1X5KhErGhgQBo8TZe9ClLCDNvO8=; b=aC1FbhMsq6ml4uIuoTuHZUljeI9cO2TXonMStux3ZCazzGLFncCFAtahk5XnhaRuFw tlLMENBHHcqV4lmW0Z+H/6VTW6wkII4sKRB92rfdS66Wi5J+rIh9aXIyInTNbqMSpywb N7hYSkgF2LoWXvzDiIL3ks88lBCC6gCF9JdEEDihO8nW+Yu8KgZeBk9vVAFV1+eb14sl I0/TYyb9e4+Xv4j4OqBQYXv1qpJu2SvKxp0IL2tucbz8QBY5TxTOU8FcDeM/j1c8WYpu X6jyzTcmsZhm7ndPPev5NMOWeyAxpJWGfPrWOG/1TRLXvtR0ynHdcIh7YBUnPdnRCN2M aYnw== X-Gm-Message-State: APjAAAWrCjDYb5vvHqdEe6WSVd+NRj1DVVpccTiD3ptsXyLwoF71trc9 6AmXo/L4BPQ5mMELKzsh09w4qw== X-Google-Smtp-Source: APXvYqzW3VtV8IUseUl13rO/O/bJcMZ87gCzy5RXZirZEP0WAh788Mbt9OB81YzwihqnHsYgNU8aYQ== X-Received: by 2002:adf:afe8:: with SMTP id y40mr17211181wrd.328.1561130368127; Fri, 21 Jun 2019 08:19:28 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id p3sm1947749wrd.47.2019.06.21.08.19.27 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Fri, 21 Jun 2019 08:19:27 -0700 (PDT) Date: Fri, 21 Jun 2019 17:19:27 +0200 From: Jiri Pirko To: Pablo Neira Ayuso Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, davem@davemloft.net, thomas.lendacky@amd.com, f.fainelli@gmail.com, ariel.elior@cavium.com, michael.chan@broadcom.com, santosh@chelsio.com, madalin.bucur@nxp.com, yisen.zhuang@huawei.com, salil.mehta@huawei.com, jeffrey.t.kirsher@intel.com, tariqt@mellanox.com, saeedm@mellanox.com, jiri@mellanox.com, idosch@mellanox.com, jakub.kicinski@netronome.com, peppe.cavallaro@st.com, grygorii.strashko@ti.com, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, alexandre.torgue@st.com, joabreu@synopsys.com, linux-net-drivers@solarflare.com, ganeshgr@chelsio.com, ogerlitz@mellanox.com, Manish.Chopra@cavium.com, marcelo.leitner@gmail.com, mkubecek@suse.cz, venkatkumar.duvvuru@broadcom.com, cphealy@gmail.com Subject: Re: [PATCH net-next 10/12] net: flow_offload: add flow_block_cb API Message-ID: <20190621151927.GB2414@nanopsycho.orion> References: <20190620194917.2298-1-pablo@netfilter.org> <20190620194917.2298-11-pablo@netfilter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190620194917.2298-11-pablo@netfilter.org> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Thu, Jun 20, 2019 at 09:49:15PM CEST, pablo@netfilter.org wrote: [...] >diff --git a/include/net/flow_offload.h b/include/net/flow_offload.h >index 36127c1858a4..728ded7e4361 100644 >--- a/include/net/flow_offload.h >+++ b/include/net/flow_offload.h >@@ -232,4 +232,56 @@ static inline void flow_stats_update(struct flow_stats *flow_stats, > flow_stats->lastused = max_t(u64, flow_stats->lastused, lastused); > } > >+#include /* for tc_setup_cb_t. */ >+ >+enum flow_block_command { >+ TC_BLOCK_BIND, >+ TC_BLOCK_UNBIND, It's not TC now. You should name these FLOW_BLOCK_BIND/UNBIND >+}; >+ >+enum flow_block_binder_type { >+ TCF_BLOCK_BINDER_TYPE_UNSPEC, >+ TCF_BLOCK_BINDER_TYPE_CLSACT_INGRESS, >+ TCF_BLOCK_BINDER_TYPE_CLSACT_EGRESS, Same here. >+}; >+ [...]