From: David Miller <davem@davemloft.net>
To: cai@lca.pw
Cc: edumazet@google.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] inet: fix compilation warnings in fqdir_pre_exit()
Date: Sun, 23 Jun 2019 11:25:27 -0700 (PDT) [thread overview]
Message-ID: <20190623.112527.356335784552993919.davem@davemloft.net> (raw)
In-Reply-To: <1561042360-20480-1-git-send-email-cai@lca.pw>
From: Qian Cai <cai@lca.pw>
Date: Thu, 20 Jun 2019 10:52:40 -0400
> The linux-next commit "inet: fix various use-after-free in defrags
> units" [1] introduced compilation warnings,
>
> ./include/net/inet_frag.h:117:1: warning: 'inline' is not at beginning
> of declaration [-Wold-style-declaration]
> static void inline fqdir_pre_exit(struct fqdir *fqdir)
> ^~~~~~
> In file included from ./include/net/netns/ipv4.h:10,
> from ./include/net/net_namespace.h:20,
> from ./include/linux/netdevice.h:38,
> from ./include/linux/icmpv6.h:13,
> from ./include/linux/ipv6.h:86,
> from ./include/net/ipv6.h:12,
> from ./include/rdma/ib_verbs.h:51,
> from ./include/linux/mlx5/device.h:37,
> from ./include/linux/mlx5/driver.h:51,
> from
> drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c:37:
>
> [1] https://lore.kernel.org/netdev/20190618180900.88939-3-edumazet@google.com/
>
> Signed-off-by: Qian Cai <cai@lca.pw>
Applied.
prev parent reply other threads:[~2019-06-23 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 14:52 [PATCH -next] inet: fix compilation warnings in fqdir_pre_exit() Qian Cai
2019-06-20 15:21 ` Eric Dumazet
2019-06-23 18:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190623.112527.356335784552993919.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cai@lca.pw \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox