From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Parshuram Thombare <pthombar@cadence.com>
Cc: andrew@lunn.ch, nicolas.ferre@microchip.com, davem@davemloft.net,
f.fainelli@gmail.com, netdev@vger.kernel.org,
hkallweit1@gmail.com, linux-kernel@vger.kernel.org,
rafalc@cadence.com, aniljoy@cadence.com, piotrs@cadence.com
Subject: Re: [PATCH v4 1/5] net: macb: add phylink support
Date: Sun, 23 Jun 2019 11:08:24 +0100 [thread overview]
Message-ID: <20190623100824.3xlmkofiqebdf4sa@shell.armlinux.org.uk> (raw)
In-Reply-To: <1561281457-6886-1-git-send-email-pthombar@cadence.com>
On Sun, Jun 23, 2019 at 10:17:37AM +0100, Parshuram Thombare wrote:
> + switch (state->interface) {
> + case PHY_INTERFACE_MODE_GMII:
> + case PHY_INTERFACE_MODE_RGMII:
> + if (bp->caps & MACB_CAPS_GIGABIT_MODE_AVAILABLE) {
> + phylink_set(mask, 1000baseT_Full);
> + phylink_set(mask, 1000baseX_Full);
> + if (!(bp->caps & MACB_CAPS_NO_GIGABIT_HALF)) {
> + phylink_set(mask, 1000baseT_Half);
> + phylink_set(mask, 1000baseT_Half);
I think this can be cleaned up.
> + }
> + }
> + /* fallthrough */
> + case PHY_INTERFACE_MODE_MII:
> + case PHY_INTERFACE_MODE_RMII:
> + phylink_set(mask, 10baseT_Half);
> + phylink_set(mask, 10baseT_Full);
> + phylink_set(mask, 100baseT_Half);
> + phylink_set(mask, 100baseT_Full);
> + break;
> + default:
> + break;
> + }
>
> - spin_lock_irqsave(&bp->lock, flags);
> + linkmode_and(supported, supported, mask);
> + linkmode_and(state->advertising, state->advertising, mask);
>
You remove this blank line in the next patch, so given that this is a
new function, you might as well clean that up in this patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
next prev parent reply other threads:[~2019-06-23 10:08 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 9:16 [PATCH v4 0/5] net: macb: cover letter Parshuram Thombare
2019-06-23 9:17 ` [PATCH v4 1/5] net: macb: add phylink support Parshuram Thombare
2019-06-23 10:08 ` Russell King - ARM Linux admin [this message]
2019-06-24 6:20 ` Parshuram Raju Thombare
2019-06-23 9:23 ` [PATCH v4 2/5] net: macb: add support for sgmii MAC-PHY interface Parshuram Thombare
2019-06-23 10:12 ` Russell King - ARM Linux admin
2019-06-24 6:35 ` Parshuram Raju Thombare
2019-06-24 9:35 ` Russell King - ARM Linux admin
2019-06-24 10:14 ` Parshuram Raju Thombare
2019-06-24 10:22 ` Russell King - ARM Linux admin
2019-06-24 10:32 ` Parshuram Raju Thombare
2019-06-23 9:23 ` [PATCH v4 3/5] net: macb: add support for c45 PHY Parshuram Thombare
2019-06-23 10:12 ` Russell King - ARM Linux admin
2019-06-24 6:47 ` Parshuram Raju Thombare
2019-06-24 9:42 ` Russell King - ARM Linux admin
2019-06-24 10:19 ` Parshuram Raju Thombare
2019-06-23 9:23 ` [PATCH v4 4/5] net: macb: add support for high speed interface Parshuram Thombare
2019-06-23 15:09 ` Andrew Lunn
2019-06-24 6:52 ` Parshuram Raju Thombare
2019-06-24 13:13 ` Andrew Lunn
2019-06-25 8:26 ` Parshuram Raju Thombare
2019-06-25 10:51 ` Russell King - ARM Linux admin
2019-06-25 11:23 ` Parshuram Raju Thombare
2019-06-23 9:24 ` [PATCH v4 5/5] net: macb: parameter added to cadence ethernet controller DT binding Parshuram Thombare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190623100824.3xlmkofiqebdf4sa@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=aniljoy@cadence.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=piotrs@cadence.com \
--cc=pthombar@cadence.com \
--cc=rafalc@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).