From: Jesper Dangaard Brouer <brouer@redhat.com>
To: <sameehj@amazon.com>
Cc: brouer@redhat.com, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <dwmw@amazon.com>,
"Machulsky, Zorik" <zorik@amazon.com>, <matua@amazon.com>,
<saeedb@amazon.com>, <msw@amazon.com>, <aliguori@amazon.com>,
<nafea@amazon.com>, <gtzalik@amazon.com>, <netanel@amazon.com>,
<alisaidi@amazon.com>, <benh@amazon.com>, <akiyano@amazon.com>,
Daniel Borkmann <borkmann@iogearbox.net>
Subject: Re: [RFC V1 net-next 1/1] net: ena: implement XDP drop support
Date: Sun, 23 Jun 2019 16:09:24 +0200 [thread overview]
Message-ID: <20190623160924.19456df5@carbon> (raw)
In-Reply-To: <20190623070649.18447-2-sameehj@amazon.com>
I'm very happy to see progress with XDP for the ENA driver.
On Sun, 23 Jun 2019 10:06:49 +0300 <sameehj@amazon.com> wrote:
> @@ -888,6 +959,15 @@ static struct sk_buff *ena_rx_skb(struct ena_ring *rx_ring,
> va = page_address(rx_info->page) + rx_info->page_offset;
> prefetch(va + NET_IP_ALIGN);
>
> + if (ena_xdp_present_ring(rx_ring)) {
> + rx_ring->xdp.data = va;
> + rx_ring->xdp.data_meta = rx_ring->xdp.data;
> + rx_ring->xdp.data_hard_start = rx_ring->xdp.data -
> + rx_info->page_offset;
> + rx_ring->xdp.data_end = rx_ring->xdp.data + len;
> + if (ena_xdp_execute(rx_ring, &rx_ring->xdp) != XDP_PASS)
> + return NULL;
> + }
Looks like you forgot to init xdp.rxq pointer.
You can use the samples/bpf/xdp_rxq_info* to access this... and this
driver will likely crash if you use it...
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2019-06-23 14:09 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-23 7:06 [RFC V1 net-next 0/1] Introduce xdp to ena sameehj
2019-06-23 7:06 ` [RFC V1 net-next 1/1] net: ena: implement XDP drop support sameehj
2019-06-23 14:09 ` Jesper Dangaard Brouer [this message]
2019-06-23 14:21 ` Jesper Dangaard Brouer
2019-06-25 3:19 ` Machulsky, Zorik
2019-06-26 8:38 ` XDP multi-buffer incl. jumbo-frames (Was: [RFC V1 net-next 1/1] net: ena: implement XDP drop support) Jesper Dangaard Brouer
2019-06-26 11:52 ` Toke Høiland-Jørgensen
2019-06-26 14:40 ` Jesper Dangaard Brouer
2019-06-26 15:01 ` Toke Høiland-Jørgensen
2019-06-26 15:20 ` Willem de Bruijn
2019-06-26 16:42 ` Jonathan Lemon
2019-06-26 20:00 ` Jesper Dangaard Brouer
2019-06-27 22:07 ` Jonathan Lemon
2019-06-28 8:46 ` Jesper Dangaard Brouer
2019-06-26 15:14 ` Toke Høiland-Jørgensen
2019-06-26 16:36 ` Jesper Dangaard Brouer
2019-06-28 7:14 ` Eelco Chaudron
2019-06-28 7:46 ` Toke Høiland-Jørgensen
2019-06-28 11:49 ` Eelco Chaudron
2019-06-28 8:22 ` Jesper Dangaard Brouer
2019-06-23 14:28 ` [RFC V1 net-next 1/1] net: ena: implement XDP drop support David Ahern
2019-06-23 14:51 ` Maciej Fijalkowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190623160924.19456df5@carbon \
--to=brouer@redhat.com \
--cc=akiyano@amazon.com \
--cc=aliguori@amazon.com \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=borkmann@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.com \
--cc=gtzalik@amazon.com \
--cc=matua@amazon.com \
--cc=msw@amazon.com \
--cc=nafea@amazon.com \
--cc=netanel@amazon.com \
--cc=netdev@vger.kernel.org \
--cc=saeedb@amazon.com \
--cc=sameehj@amazon.com \
--cc=zorik@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).