From: Jakub Kicinski <jakub.kicinski@netronome.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Igor Russkikh <Igor.Russkikh@aquantia.com>,
"David S . Miller" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts
Date: Sun, 23 Jun 2019 20:49:54 -0700 [thread overview]
Message-ID: <20190623204954.3aa09ded@cakuba> (raw)
In-Reply-To: <20190622150514.GB8497@lunn.ch>
On Sat, 22 Jun 2019 17:05:14 +0200, Andrew Lunn wrote:
> On Sat, Jun 22, 2019 at 01:45:12PM +0000, Igor Russkikh wrote:
> > As it was discussed some time previously, driver is better to
> > report kernel version string, as it in a best way identifies
> > the codebase.
> >
> > Signed-off-by: Igor Russkikh <igor.russkikh@aquantia.com>
>
> Nice.
Indeed!
> Devlink has just gained something similar to ethtool -i. Maybe we
> should get the devlink core to also report the kernel version?
I don't think we have the driver version at all there, my usual
inclination being to not duplicate information across APIs. Do we
have non-hypothetical instances of users reporting ethtool -i without
uname output? Admittedly I may work with above-average Linux-trained
engineers :S Would it be okay to just get devlink user space to use
uname() to get the info?
next prev parent reply other threads:[~2019-06-24 3:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-22 13:45 [PATCH net-next 0/7] net: aquantia: implement vlan offloads Igor Russkikh
2019-06-22 13:45 ` [PATCH net-next 1/7] net: aquantia: replace internal driver version code with uts Igor Russkikh
2019-06-22 15:05 ` Andrew Lunn
2019-06-24 3:49 ` Jakub Kicinski [this message]
2019-06-24 11:02 ` Igor Russkikh
2019-06-24 15:04 ` David Miller
2019-06-22 13:45 ` [PATCH net-next 2/7] net: aquantia: add documentation for the atlantic driver Igor Russkikh
2019-06-22 15:16 ` Andrew Lunn
2019-06-24 11:17 ` Igor Russkikh
2019-06-22 13:45 ` [PATCH net-next 3/7] maintainers: declare aquantia atlantic driver maintenance Igor Russkikh
2019-06-22 15:18 ` Andrew Lunn
2019-06-22 13:45 ` [PATCH net-next 4/7] net: aquantia: added vlan offload related macros and functions Igor Russkikh
2019-06-22 13:45 ` [PATCH net-next 5/7] net: aquantia: adding fields and device features for vlan offload Igor Russkikh
2019-06-22 13:45 ` [PATCH net-next 6/7] net: aquantia: vlan offloads logic in datapath Igor Russkikh
2019-06-22 13:45 ` [PATCH net-next 7/7] net: aquantia: implement vlan offload configuration Igor Russkikh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190623204954.3aa09ded@cakuba \
--to=jakub.kicinski@netronome.com \
--cc=Igor.Russkikh@aquantia.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).